2023-07-09 21:32:16

by Thomas Weißschuh

Subject: [PATCH v2 1/3] dyndbg: constify opt_array

It is never modified, so mark it const.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
lib/dynamic_debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index fdd6d9800a70..71b22d206a1b 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -88,7 +88,7 @@ static inline const char *trim_prefix(const char *path)
return path + skip;
}

-static struct { unsigned flag:8; char opt_char; } opt_array[] = {
+static const struct { unsigned flag:8; char opt_char; } opt_array[] = {
{ _DPRINTK_FLAGS_PRINT, 'p' },
{ _DPRINTK_FLAGS_INCL_MODNAME, 'm' },
{ _DPRINTK_FLAGS_INCL_FUNCNAME, 'f' },

--
2.41.0

2023-07-10 19:36:02

by Luis Chamberlain

Subject: Re: [PATCH v2 1/3] dyndbg: constify opt_array

On Sun, Jul 09, 2023 at 11:17:58PM +0200, Thomas Wei?schuh wrote:
> It is never modified, so mark it const.
>
> Signed-off-by: Thomas Wei?schuh <[email protected]>

Reviewed-by: Luis Chamberlain <[email protected]>

Luis