2023-07-09 14:57:00

by xuanzhenggang001

Subject: [PATCH] MIPS: prefer 'unsigned int' to bare use of 'unsigned'

Fix the following warnings reported by checkpatch:

arch/mips/kernel/linux32.c:128: WARNING: Prefer 'unsigned int' to bare
use of 'unsigned'
arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare
use of 'unsigned'
arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare
use of 'unsigned'
arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare
use of 'unsigned'

Signed-off-by: Zhenggang Xuan <[email protected]>
---
arch/mips/kernel/linux32.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/kernel/linux32.c b/arch/mips/kernel/linux32.c
index 6b61be486303..4bd52b38dd00 100644
--- a/arch/mips/kernel/linux32.c
+++ b/arch/mips/kernel/linux32.c
@@ -125,8 +125,8 @@ asmlinkage long sys32_fadvise64_64(int fd, int
__pad,
flags);
}

-asmlinkage long sys32_fallocate(int fd, int mode, unsigned offset_a2,
- unsigned offset_a3, unsigned len_a4, unsigned len_a5)
+asmlinkage long sys32_fallocate(int fd, int mode, unsigned int
offset_a2,
+ unsigned int offset_a3, unsigned int len_a4, unsigned int len_a5)
{
return ksys_fallocate(fd, mode, merge_64(offset_a2, offset_a3),
merge_64(len_a4, len_a5));

2023-07-11 12:11:42

by Philippe Mathieu-Daudé

Subject: Re: [PATCH] MIPS: prefer 'unsigned int' to bare use of 'unsigned'

On 9/7/23 16:19, [email protected] wrote:
> Fix the following warnings reported by checkpatch:
>
> arch/mips/kernel/linux32.c:128: WARNING: Prefer 'unsigned int' to bare
> use of 'unsigned'
> arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare
> use of 'unsigned'
> arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare
> use of 'unsigned'
> arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare
> use of 'unsigned'
>
> Signed-off-by: Zhenggang Xuan <[email protected]>
> ---
>  arch/mips/kernel/linux32.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>

2023-07-25 09:23:07

by Thomas Bogendoerfer

Subject: Re: [PATCH] MIPS: prefer 'unsigned int' to bare use of 'unsigned'

On Sun, Jul 09, 2023 at 10:19:50PM +0800, [email protected] wrote:
> Fix the following warnings reported by checkpatch:
>
> arch/mips/kernel/linux32.c:128: WARNING: Prefer 'unsigned int' to bare use
> of 'unsigned'
> arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use
> of 'unsigned'
> arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use
> of 'unsigned'
> arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use
> of 'unsigned'
>
> Signed-off-by: Zhenggang Xuan <[email protected]>
> ---
> arch/mips/kernel/linux32.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/kernel/linux32.c b/arch/mips/kernel/linux32.c
> index 6b61be486303..4bd52b38dd00 100644
> --- a/arch/mips/kernel/linux32.c
> +++ b/arch/mips/kernel/linux32.c
> @@ -125,8 +125,8 @@ asmlinkage long sys32_fadvise64_64(int fd, int __pad,
> flags);
> }
>
> -asmlinkage long sys32_fallocate(int fd, int mode, unsigned offset_a2,
> - unsigned offset_a3, unsigned len_a4, unsigned len_a5)
> +asmlinkage long sys32_fallocate(int fd, int mode, unsigned int offset_a2,
> + unsigned int offset_a3, unsigned int len_a4, unsigned int len_a5)
> {
> return ksys_fallocate(fd, mode, merge_64(offset_a2, offset_a3),
> merge_64(len_a4, len_a5));

this is white-space damaged, please resend with that corrected.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]