2023-07-20 03:01:16

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the chrome-platform tree

Hi all,

After merging the chrome-platform tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: modpost: "emergency_sync" [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!

Caused by commit

a6edd5f5d9cc ("platform/chrome: cros_ec_lpc: Emergency sync filesystem on EC panic")

I have used the chrome-platform tree from next-20230719 for today.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2023-07-20 05:10:27

by Tzung-Bi Shih

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the chrome-platform tree

On Thu, Jul 20, 2023 at 12:46:11PM +1000, Stephen Rothwell wrote:
> After merging the chrome-platform tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: modpost: "emergency_sync" [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!
>
> Caused by commit
>
> a6edd5f5d9cc ("platform/chrome: cros_ec_lpc: Emergency sync filesystem on EC panic")
>
> I have used the chrome-platform tree from next-20230719 for today.

Thanks for reporting. I have dropped the commit from chrome-platform for-next
branch until a fix is seen.

2023-07-20 05:22:23

by Tzung-Bi Shih

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the chrome-platform tree

On Thu, Jul 20, 2023 at 12:46:11PM +1000, Stephen Rothwell wrote:
> After merging the chrome-platform tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: modpost: "emergency_sync" [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!
>
> Caused by commit
>
> a6edd5f5d9cc ("platform/chrome: cros_ec_lpc: Emergency sync filesystem on EC panic")
>
> I have used the chrome-platform tree from next-20230719 for today.

Thanks for reporting. I have dropped the commit from chrome-platform for-next
branch.

2023-07-20 15:49:38

by Rob Barnes

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the chrome-platform tree

The patch to fix this issue was submitted here:
https://lore.kernel.org/lkml/[email protected]/T/

However, it's looking unlikely that it will be accepted. So I think we
should revert a6edd5f5d9cc for now. Let me know if I need to submit a
revert patch?

On Wed, Jul 19, 2023 at 11:00 PM Tzung-Bi Shih <[email protected]> wrote:
>
> On Thu, Jul 20, 2023 at 12:46:11PM +1000, Stephen Rothwell wrote:
> > After merging the chrome-platform tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > ERROR: modpost: "emergency_sync" [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!
> >
> > Caused by commit
> >
> > a6edd5f5d9cc ("platform/chrome: cros_ec_lpc: Emergency sync filesystem on EC panic")
> >
> > I have used the chrome-platform tree from next-20230719 for today.
>
> Thanks for reporting. I have dropped the commit from chrome-platform for-next
> branch.

2023-07-21 07:50:14

by Tzung-Bi Shih

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the chrome-platform tree

On Thu, Jul 20, 2023 at 09:32:11AM -0600, Rob Barnes wrote:
> The patch to fix this issue was submitted here:
> https://lore.kernel.org/lkml/[email protected]/T/
>
> However, it's looking unlikely that it will be accepted. So I think we
> should revert a6edd5f5d9cc for now. Let me know if I need to submit a
> revert patch?

No, you don't need to send a revert patch. I'll remove it from the queue
if the symbol can't get exported for now.