2023-07-19 00:56:31

by Yang Li

[permalink] [raw]
Subject: [PATCH -next] phy: Remove duplicated include in xusb.c

./drivers/phy/tegra/xusb.c: linux/platform_device.h is included more than once.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5930
Signed-off-by: Yang Li <[email protected]>
---
drivers/phy/tegra/xusb.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index ed30866e7647..142ebe0247cc 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -12,7 +12,6 @@
#include <linux/phy/phy.h>
#include <linux/phy/tegra/xusb.h>
#include <linux/platform_device.h>
-#include <linux/platform_device.h>
#include <linux/regulator/consumer.h>
#include <linux/reset.h>
#include <linux/slab.h>
--
2.20.1.7.g153144c



2023-07-21 14:09:26

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH -next] phy: Remove duplicated include in xusb.c

On Wed, Jul 19, 2023 at 08:36:14AM +0800, Yang Li wrote:
> ./drivers/phy/tegra/xusb.c: linux/platform_device.h is included more than once.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5930
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/phy/tegra/xusb.c | 1 -
> 1 file changed, 1 deletion(-)

It's typical to list the maintainers on the "To:" line to increase the
chances of them noticing. This is obviously correct, so:

Acked-by: Thierry Reding <[email protected]>

>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index ed30866e7647..142ebe0247cc 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -12,7 +12,6 @@
> #include <linux/phy/phy.h>
> #include <linux/phy/tegra/xusb.h>
> #include <linux/platform_device.h>
> -#include <linux/platform_device.h>
> #include <linux/regulator/consumer.h>
> #include <linux/reset.h>
> #include <linux/slab.h>
> --
> 2.20.1.7.g153144c
>


Attachments:
(No filename) (1.03 kB)
signature.asc (849.00 B)
Download all attachments

2023-07-24 11:10:02

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH -next] phy: Remove duplicated include in xusb.c


On Wed, 19 Jul 2023 08:36:14 +0800, Yang Li wrote:
> ./drivers/phy/tegra/xusb.c: linux/platform_device.h is included more than once.
>
>

Applied, thanks!

[1/1] phy: Remove duplicated include in xusb.c
commit: f5a8ecef3c6b840673d08342045c3014d674555f

Best regards,
--
~Vinod