2023-07-21 14:28:05

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v3 38/42] ata: pata_ep93xx: remove legacy pinctrl use

On Thu, Jul 20, 2023 at 02:29:38PM +0300, Nikita Shubin via B4 Relay wrote:
> From: Nikita Shubin <[email protected]>
>
> Drop legacy acquire/release since we are using pinctrl for this now.

...

> drv_data = devm_kzalloc(&pdev->dev, sizeof(*drv_data), GFP_KERNEL);
> - if (!drv_data) {
> - err = -ENOMEM;
> - goto err_rel_gpio;
> - }
> + if (!drv_data)
> + return -ENXIO;

Wrong error code. See above what you have deleted.

--
With Best Regards,
Andy Shevchenko