2023-07-21 20:03:13

by Catalin Marinas

[permalink] [raw]
Subject: Re: [PATCH v11 2/4] mm/tlbbatch: Rename and extend some functions

On Mon, Jul 17, 2023 at 09:10:02PM +0800, Yicong Yang wrote:
> From: Barry Song <[email protected]>
>
> This patch does some preparation works to extend batched TLB flush to
> arm64. Including:
> - Extend set_tlb_ubc_flush_pending() and arch_tlbbatch_add_mm()
> to accept an additional argument for address, architectures
> like arm64 may need this for tlbi.
> - Rename arch_tlbbatch_add_mm() to arch_tlbbatch_add_pending()
> to match its current function since we don't need to handle
> mm on architectures like arm64 and add_mm is not proper,
> add_pending will make sense to both as on x86 we're pending the
> TLB flush operations while on arm64 we're pending the synchronize
> operations.
>
> This intends no functional changes on x86.
>
> Cc: Anshuman Khandual <[email protected]>
> Cc: Jonathan Corbet <[email protected]>
> Cc: Nadav Amit <[email protected]>
> Cc: Mel Gorman <[email protected]>
> Tested-by: Yicong Yang <[email protected]>
> Tested-by: Xin Hao <[email protected]>
> Tested-by: Punit Agrawal <[email protected]>
> Signed-off-by: Barry Song <[email protected]>
> Signed-off-by: Yicong Yang <[email protected]>
> Reviewed-by: Kefeng Wang <[email protected]>
> Reviewed-by: Xin Hao <[email protected]>
> Reviewed-by: Anshuman Khandual <[email protected]>

Reviewed-by: Catalin Marinas <[email protected]>