2023-08-05 09:32:58

by Pavan Bobba

Subject: [PATCH v2] staging: vt6655: replace camel case by snake case

Replace array name of camel case by snake case. Issue found
by checkpatch

Signed-off-by: Pavan Bobba <[email protected]>
---
v1 -> v2: 1.character '_' added in the array name "byvt3253b0_rfmde"
2. typo in the subject line "small case" corrected with the
proper word "snake case"

drivers/staging/vt6655/baseband.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
index 0e135af8316b..8b913c64845c 100644
--- a/drivers/staging/vt6655/baseband.c
+++ b/drivers/staging/vt6655/baseband.c
@@ -499,7 +499,7 @@ static const unsigned char by_vt3253_init_tab_rfmd[CB_VT3253_INIT_FOR_RFMD][2] =
};

#define CB_VT3253B0_INIT_FOR_RFMD 256
-static const unsigned char byVT3253B0_RFMD[CB_VT3253B0_INIT_FOR_RFMD][2] = {
+static const unsigned char byvt3253b0_rfmd[CB_VT3253B0_INIT_FOR_RFMD][2] = {
{0x00, 0x31},
{0x01, 0x00},
{0x02, 0x00},
@@ -2005,8 +2005,8 @@ bool bb_vt3253_init(struct vnt_private *priv)
} else {
for (ii = 0; ii < CB_VT3253B0_INIT_FOR_RFMD; ii++)
result &= bb_write_embedded(priv,
- byVT3253B0_RFMD[ii][0],
- byVT3253B0_RFMD[ii][1]);
+ byvt3253b0_rfmd[ii][0],
+ byvt3253b0_rfmd[ii][1]);

for (ii = 0; ii < CB_VT3253B0_AGC_FOR_RFMD2959; ii++)
result &= bb_write_embedded(priv,
--
2.34.1

2023-08-05 17:29:00

by Dan Carpenter

Subject: Re: [PATCH v2] staging: vt6655: replace camel case by snake case

On Sat, Aug 05, 2023 at 02:29:04PM +0530, Pavan Bobba wrote:
> Replace array name of camel case by snake case. Issue found
> by checkpatch
>
> Signed-off-by: Pavan Bobba <[email protected]>
> ---
> v1 -> v2: 1.character '_' added in the array name "byvt3253b0_rfmde"

You never actually added a _ character. It should be by_vt3253b0_rfmde.

regards,
dan carpenter

2023-08-09 12:54:31

by Greg Kroah-Hartman

Subject: Re: [PATCH v2] staging: vt6655: replace camel case by snake case

On Sat, Aug 05, 2023 at 02:29:04PM +0530, Pavan Bobba wrote:
> Replace array name of camel case by snake case. Issue found
> by checkpatch
>
> Signed-off-by: Pavan Bobba <[email protected]>
> ---
> v1 -> v2: 1.character '_' added in the array name "byvt3253b0_rfmde"
> 2. typo in the subject line "small case" corrected with the
> proper word "snake case"
>
> drivers/staging/vt6655/baseband.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
> index 0e135af8316b..8b913c64845c 100644
> --- a/drivers/staging/vt6655/baseband.c
> +++ b/drivers/staging/vt6655/baseband.c
> @@ -499,7 +499,7 @@ static const unsigned char by_vt3253_init_tab_rfmd[CB_VT3253_INIT_FOR_RFMD][2] =
> };
>
> #define CB_VT3253B0_INIT_FOR_RFMD 256
> -static const unsigned char byVT3253B0_RFMD[CB_VT3253B0_INIT_FOR_RFMD][2] = {
> +static const unsigned char byvt3253b0_rfmd[CB_VT3253B0_INIT_FOR_RFMD][2] = {

The "by" here means "byte", a horrible naming scheme that was popular in
the 1990's when C compilers would not check the types of variables. No
need for that here, this should just be "vt3253b0_rfmd", right?

thanks,

greg k-h