v6 changes:
- PATCH RESEND, the v5 was approved was not committed, Ira suggested to
resend both patches.
v5 changes:
- Updated the missing reviewed tag in "cxl/mbox: Remove redundant
dev_err() after failed mem alloc" patch (Dave Jiang)
v4 changes:
- Updated the respective patches with reviewers tags for respective
patches(Dave Jiang)
v3 changes:
- Update the cover letter and commit message with full author
name(Fabio/Alison)
- Correct the "typo error" in commit message(Fabio)
v2 changes:
Thanks Alison, Ira for your comments, modified the v1 patches as
suggested.
Dropped the patch containing tab changes in port.c
v1 cover letter:
The following patches are cleanup or fixing the styling issues found
using checkpatch
In cxl/core/mbox.c, in case of null check failure, returning errno or
-ENOMEM in this case is good enough, removing the redundant dev_err
message.
In cxl/core/region.c, the else is not required after the return
statement, cleaned it up.
Verified the build and sanity by booting the guest VM using the freshly
built components.
Raghu Halharvi (2):
cxl/mbox: Remove redundant dev_err() after failed mem alloc
cxl/region: Remove else after return statement
drivers/cxl/core/mbox.c | 4 +---
drivers/cxl/core/region.c | 8 ++++----
2 files changed, 5 insertions(+), 7 deletions(-)
--
2.39.2
On Tue, Jul 25, 2023 at 12:19:28PM +0000, Raghu Halharvi wrote:
> v6 changes:
> - PATCH RESEND, the v5 was approved was not committed, Ira suggested to
> resend both patches.
Hi Raghu,
If this was a true RESEND, the version number should not have changed.
See: Documentation/process/submitting-patches.rst
Alas, this v6 has changes from v5 that are not listed here, so this
is not a RESEND, it is a new version.
Both patches were rebased, and in Patch 1 that led to a changed
function name too.
What to do?
How about you send a reply to this cover letter with the v5->v6
changelog, and let's see if that's clear enough.
Thanks,
Alison
>
> v5 changes:
> - Updated the missing reviewed tag in "cxl/mbox: Remove redundant
> dev_err() after failed mem alloc" patch (Dave Jiang)
>
> v4 changes:
> - Updated the respective patches with reviewers tags for respective
> patches(Dave Jiang)
>
> v3 changes:
> - Update the cover letter and commit message with full author
> name(Fabio/Alison)
> - Correct the "typo error" in commit message(Fabio)
>
> v2 changes:
> Thanks Alison, Ira for your comments, modified the v1 patches as
> suggested.
> Dropped the patch containing tab changes in port.c
>
> v1 cover letter:
> The following patches are cleanup or fixing the styling issues found
> using checkpatch
>
> In cxl/core/mbox.c, in case of null check failure, returning errno or
> -ENOMEM in this case is good enough, removing the redundant dev_err
> message.
>
> In cxl/core/region.c, the else is not required after the return
> statement, cleaned it up.
>
> Verified the build and sanity by booting the guest VM using the freshly
> built components.
>
> Raghu Halharvi (2):
> cxl/mbox: Remove redundant dev_err() after failed mem alloc
> cxl/region: Remove else after return statement
>
> drivers/cxl/core/mbox.c | 4 +---
> drivers/cxl/core/region.c | 8 ++++----
> 2 files changed, 5 insertions(+), 7 deletions(-)
>
> --
> 2.39.2
>