2023-07-27 16:53:29

by Duje Mihanović

Subject: [PATCH v2 1/9] gpio: pxa: disable pinctrl calls for MMP_GPIO

Similarly to PXA3xx and MMP2, pinctrl-single isn't capable of setting
pin direction on MMP either.

Fixes: a770d946371e ("gpio: pxa: add pin control gpio direction and request")
Signed-off-by: Duje Mihanović <[email protected]>
---
drivers/gpio/gpio-pxa.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index a1630ed4b741..d92650aecb06 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -238,6 +238,7 @@ static bool pxa_gpio_has_pinctrl(void)
switch (gpio_type) {
case PXA3XX_GPIO:
case MMP2_GPIO:
+ case MMP_GPIO:
return false;

default:
--
2.41.0

2023-07-27 17:20:47

by Andy Shevchenko

Subject: Re: [PATCH v2 1/9] gpio: pxa: disable pinctrl calls for MMP_GPIO

On Thu, Jul 27, 2023 at 06:28:59PM +0200, Duje Mihanović wrote:
> Similarly to PXA3xx and MMP2, pinctrl-single isn't capable of setting
> pin direction on MMP either.

Reviewed-by: Andy Shevchenko <[email protected]>

(Hadn't I already given you a tag?)

--
With Best Regards,
Andy Shevchenko