2023-07-27 01:44:40

by Rob Herring

Subject: [PATCH] MIPS: Fixup explicit DT include clean-up

Commit 657c45b303f87d77 ("MIPS: Explicitly include correct DT includes")
removed a necessary include by mistake and missed adding an explicit
include of spinlock.h (from of.h -> kobject.h -> spinlock.h).

Fixes: 657c45b303f87d77 ("MIPS: Explicitly include correct DT includes")
Reported-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: Rob Herring <[email protected]>
---
arch/mips/lantiq/xway/gptu.c | 1 +
arch/mips/pic32/pic32mzda/config.c | 1 +
2 files changed, 2 insertions(+)

diff --git a/arch/mips/lantiq/xway/gptu.c b/arch/mips/lantiq/xway/gptu.c
index e254b108fb9b..8d52001301de 100644
--- a/arch/mips/lantiq/xway/gptu.c
+++ b/arch/mips/lantiq/xway/gptu.c
@@ -9,6 +9,7 @@
#include <linux/ioport.h>
#include <linux/init.h>
#include <linux/mod_devicetable.h>
+#include <linux/of_irq.h>
#include <linux/platform_device.h>

#include <lantiq_soc.h>
diff --git a/arch/mips/pic32/pic32mzda/config.c b/arch/mips/pic32/pic32mzda/config.c
index 6e94ae66eba8..73be5689e0df 100644
--- a/arch/mips/pic32/pic32mzda/config.c
+++ b/arch/mips/pic32/pic32mzda/config.c
@@ -5,6 +5,7 @@
*/
#include <linux/init.h>
#include <linux/io.h>
+#include <linux/spinlock.h>

#include <asm/mach-pic32/pic32.h>

--
2.40.1

2023-07-28 10:26:32

by Thomas Bogendoerfer

Subject: Re: [PATCH] MIPS: Fixup explicit DT include clean-up

On Wed, Jul 26, 2023 at 07:20:28PM -0600, Rob Herring wrote:
> Commit 657c45b303f87d77 ("MIPS: Explicitly include correct DT includes")
> removed a necessary include by mistake and missed adding an explicit
> include of spinlock.h (from of.h -> kobject.h -> spinlock.h).
>
> Fixes: 657c45b303f87d77 ("MIPS: Explicitly include correct DT includes")
> Reported-by: Geert Uytterhoeven <[email protected]>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> arch/mips/lantiq/xway/gptu.c | 1 +
> arch/mips/pic32/pic32mzda/config.c | 1 +
> 2 files changed, 2 insertions(+)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]