Fixed all CHECK: Alignment should match open parenthesis
as reported by checkpatch to adhere to the Linux kernel
coding-style guidelines.
Signed-off-by: Alexon Oliveira <[email protected]>
---
drivers/staging/vme_user/vme.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
index 977c81e2f3c7..741593d75a63 100644
--- a/drivers/staging/vme_user/vme.c
+++ b/drivers/staging/vme_user/vme.c
@@ -563,7 +563,7 @@ EXPORT_SYMBOL(vme_master_request);
* returned.
*/
int vme_master_set(struct vme_resource *resource, int enabled,
- unsigned long long vme_base, unsigned long long size,
+ unsigned long long vme_base, unsigned long long size,
u32 aspace, u32 cycle, u32 dwidth)
{
struct vme_bridge *bridge = find_bridge(resource);
@@ -614,7 +614,7 @@ EXPORT_SYMBOL(vme_master_set);
* device or if an invalid resource has been provided.
*/
int vme_master_get(struct vme_resource *resource, int *enabled,
- unsigned long long *vme_base, unsigned long long *size,
+ unsigned long long *vme_base, unsigned long long *size,
u32 *aspace, u32 *cycle, u32 *dwidth)
{
struct vme_bridge *bridge = find_bridge(resource);
@@ -1045,7 +1045,7 @@ EXPORT_SYMBOL(vme_dma_pci_attribute);
* Return: Pointer to VME DMA attribute, NULL on failure.
*/
struct vme_dma_attr *vme_dma_vme_attribute(unsigned long long address,
- u32 aspace, u32 cycle,
+ u32 aspace, u32 cycle,
u32 dwidth)
{
struct vme_dma_attr *attributes;
@@ -1841,7 +1841,7 @@ EXPORT_SYMBOL(vme_unregister_bridge);
/* - Driver Registration --------------------------------------------------- */
static int __vme_register_driver_bus(struct vme_driver *drv,
- struct vme_bridge *bridge,
+ struct vme_bridge *bridge,
unsigned int ndevs)
{
int err;
--
2.41.0
On Fri, Aug 04, 2023 at 06:20:50PM -0300, Alexon Oliveira wrote:
> Fixed all CHECK: Alignment should match open parenthesis
> as reported by checkpatch to adhere to the Linux kernel
> coding-style guidelines.
This does not describe the changes you actually made in this patch :(
On Sat, Aug 05, 2023 at 08:14:33AM +0200, Greg KH wrote:
> On Fri, Aug 04, 2023 at 06:20:50PM -0300, Alexon Oliveira wrote:
> > Fixed all CHECK: Alignment should match open parenthesis
> > as reported by checkpatch to adhere to the Linux kernel
> > coding-style guidelines.
>
> This does not describe the changes you actually made in this patch :(
>
Hi Greg,
Thank you for your feedback. Don't get me wrong, please, I'm just trying
to understand it now, but honestly I don't know what is wrong with
it this time. I described exactly what I did in the code: ran the
checkpatch, which identified a lot of "CHECK: Alignment should match
open parenthesis" messages, fixed them all according to the coding-style
guidelines and comitted it.
This is the same thing I did previously for the file
drivers/staging/vme_user/vme_bridge.h in the commit
7d5ce25fb4c3cc91d16e27163dc141de0eba213b, but now is the file
drivers/staging/vme_user/vme.c and commit
a1f0b0a8ba9a496504c2e3d4b37cee388e78f0ea. Different files,
different commits, similar fixes for the same warnings,
and same description.
The only thing I found strange is because instead of starting a new
email thread it ended up in the same email thread as the previous
patch. Would that be the problem?
If not, would you mind, please, to explain to me what would be the most
appropriate way you'd like me to write this changelog?
I really appreciate your patience and help.
Thank you.
Regards.
On Mon, Aug 07, 2023 at 12:13:40PM -0300, Alexon Oliveira wrote:
> On Sat, Aug 05, 2023 at 08:14:33AM +0200, Greg KH wrote:
> > On Fri, Aug 04, 2023 at 06:20:50PM -0300, Alexon Oliveira wrote:
> > > Fixed all CHECK: Alignment should match open parenthesis
> > > as reported by checkpatch to adhere to the Linux kernel
> > > coding-style guidelines.
> >
> > This does not describe the changes you actually made in this patch :(
> >
> Hi Greg,
>
> Thank you for your feedback. Don't get me wrong, please, I'm just trying
> to understand it now, but honestly I don't know what is wrong with
> it this time. I described exactly what I did in the code: ran the
> checkpatch, which identified a lot of "CHECK: Alignment should match
> open parenthesis" messages, fixed them all according to the coding-style
> guidelines and comitted it.
But you did not change the alignment of the open parenthesis, right?
You deleted the trailing whitespace.
>
> This is the same thing I did previously for the file
> drivers/staging/vme_user/vme_bridge.h in the commit
> 7d5ce25fb4c3cc91d16e27163dc141de0eba213b, but now is the file
> drivers/staging/vme_user/vme.c and commit
> a1f0b0a8ba9a496504c2e3d4b37cee388e78f0ea. Different files,
> different commits, similar fixes for the same warnings,
> and same description.
>
> The only thing I found strange is because instead of starting a new
> email thread it ended up in the same email thread as the previous
> patch. Would that be the problem?
That would be a problem, and it seems you used the same subject line as
previous patches that were different?
Anyway, my comment was about the trailing whitespace change.
thanks,
greg k-h
On Mon, Aug 07, 2023 at 05:26:04PM +0200, Greg KH wrote:
> On Mon, Aug 07, 2023 at 12:13:40PM -0300, Alexon Oliveira wrote:
> > On Sat, Aug 05, 2023 at 08:14:33AM +0200, Greg KH wrote:
> > > On Fri, Aug 04, 2023 at 06:20:50PM -0300, Alexon Oliveira wrote:
> > > > Fixed all CHECK: Alignment should match open parenthesis
> > > > as reported by checkpatch to adhere to the Linux kernel
> > > > coding-style guidelines.
> > >
> > > This does not describe the changes you actually made in this patch :(
> > >
> > Hi Greg,
> >
> > Thank you for your feedback. Don't get me wrong, please, I'm just trying
> > to understand it now, but honestly I don't know what is wrong with
> > it this time. I described exactly what I did in the code: ran the
> > checkpatch, which identified a lot of "CHECK: Alignment should match
> > open parenthesis" messages, fixed them all according to the coding-style
> > guidelines and comitted it.
>
> But you did not change the alignment of the open parenthesis, right?
> You deleted the trailing whitespace.
>
Hmm, I did both, but the last one I did right before commit, due a final
check. But you're right, I forgot to mention it in the changelog as
well. I'm going to submit a new patch with the correct description.
Thank you for the explanation.
> >
> > This is the same thing I did previously for the file
> > drivers/staging/vme_user/vme_bridge.h in the commit
> > 7d5ce25fb4c3cc91d16e27163dc141de0eba213b, but now is the file
> > drivers/staging/vme_user/vme.c and commit
> > a1f0b0a8ba9a496504c2e3d4b37cee388e78f0ea. Different files,
> > different commits, similar fixes for the same warnings,
> > and same description.
> >
> > The only thing I found strange is because instead of starting a new
> > email thread it ended up in the same email thread as the previous
> > patch. Would that be the problem?
>
> That would be a problem, and it seems you used the same subject line as
> previous patches that were different?
>
Yep, used same subject line. I'm going to change it slightly to not
extend this thread, since it's a commit for a different file.
> Anyway, my comment was about the trailing whitespace change.
>
ACK
> thanks,
>
> greg k-h
Thank you.
Alexon Oliveira