2023-08-11 14:09:25

by Arnd Bergmann

Subject: [PATCH] radix tree: remove unused variable

From: Arnd Bergmann <[email protected]>

Recent versions of clang warn about an unused variable, though older
versions saw the 'slot++' as a use and did not warn:

radix-tree.c:1136:50: error: parameter 'slot' set but not used [-Werror,-Wunused-but-set-parameter]

It's clearly not needed any more, so just remove it.

Fixes: 3a08cd52c37c7 ("radix tree: Remove multiorder support")
Signed-off-by: Arnd Bergmann <[email protected]>
---
lib/radix-tree.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/lib/radix-tree.c b/lib/radix-tree.c
index 1a31065b2036a..976b9bd02a1b5 100644
--- a/lib/radix-tree.c
+++ b/lib/radix-tree.c
@@ -1136,7 +1136,6 @@ static void set_iter_tags(struct radix_tree_iter *iter,
void __rcu **radix_tree_iter_resume(void __rcu **slot,
struct radix_tree_iter *iter)
{
- slot++;
iter->index = __radix_tree_iter_add(iter, 1);
iter->next_index = iter->index;
iter->tags = 0;
--
2.39.2

2023-08-11 14:43:39

by Matthew Wilcox

Subject: Re: [PATCH] radix tree: remove unused variable

On Fri, Aug 11, 2023 at 03:10:13PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> Recent versions of clang warn about an unused variable, though older
> versions saw the 'slot++' as a use and did not warn:
>
> radix-tree.c:1136:50: error: parameter 'slot' set but not used [-Werror,-Wunused-but-set-parameter]
>
> It's clearly not needed any more, so just remove it.
>
> Fixes: 3a08cd52c37c7 ("radix tree: Remove multiorder support")

Thanks!