> There was some discussion [1] wherein it was ultimately decided that
> this warning should probably be turned off (contrary to what the title
> of the GitHub issue says).
I totally agree with your last comment in [1]. So, I also vote for
disabling the warning. Thus, I will reject these patches, but still
thank you for looking into such issues and trying to solve them!
> [1]: https://github.com/ClangBuiltLinux/linux/issues/1910
Hi,
> > There was some discussion [1] wherein it was ultimately decided that
> > this warning should probably be turned off (contrary to what the title
> > of the GitHub issue says).
>
> I totally agree with your last comment in [1]. So, I also vote for
> disabling the warning. Thus, I will reject these patches, but still
> thank you for looking into such issues and trying to solve them!
yes, unfortunately this is the trend and most of the patches
follow this approach and they are getting merged.
I don't like pointers storing values and this fix whould be
completely taken from another side. In any case, given the trend,
I will not oppose.
Andi