2023-08-28 09:22:56

by Thomas Bogendoerfer

[permalink] [raw]
Subject: Re: [PATCH v2 2/8] MIPS: TXx9: Do PCI error checks on own line

On Sun, Aug 27, 2023 at 04:36:59PM +0300, Ilpo J?rvinen wrote:
> Instead of if conditions with line splits, use the usual error handling
> pattern with a separate variable to improve readability.
>
> The second check can use reverse logic which reduces indentation level.
>
> No functional changes intended.
>
> Signed-off-by: Ilpo J?rvinen <[email protected]>
> Reviewed-by: Philippe Mathieu-Daud? <[email protected]>
> ---
> arch/mips/txx9/generic/pci.c | 43 +++++++++++++++++++-----------------
> 1 file changed, 23 insertions(+), 20 deletions(-)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]