2023-09-18 21:10:57

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v2] platform/x86: think-lmi: Add bulk save feature

On Mon, Sep 18, 2023 at 04:07:53PM +0200, Hans de Goede wrote:
> On 9/18/23 15:57, Andy Shevchenko wrote:
> > On Wed, Sep 06, 2023 at 08:13:14AM -0400, Mark Pearson wrote:

...

> >> +/* There are a limit on the number of WMI operations you can do if you use
> >> + * the default implementation of saving on every set. This is due to a
> >> + * limitation in EFI variable space used.
> >> + * Have a 'bulk save' mode where you can manually trigger the save, and can
> >> + * therefore set unlimited variables - for users that need it.
> >> + */
> >
> > /*
> > * This is wrong multi-line comment style. This one
> > * is used solely in net subsystem.
> > */
>
> Good catch, Mark can you fix this one too please ?
>
> Also I thought that checkpatch.pl used to catch this ?

I don't think it recognizes "net style is only for net related files".

--
With Best Regards,
Andy Shevchenko