2023-09-21 19:01:52

by Andy Shevchenko

Subject: Re: [PATCH V2 2/2] gpio: pmic-eic-sprd: Add can_sleep flag for PMIC EIC chip

On Thu, Sep 21, 2023 at 08:25:27PM +0800, Wenhua Lin wrote:
> The drivers uses a mutex and I2C bus access in its PMIC EIC chip
> get implementation. This means these functions can sleep and the PMIC EIC
> chip should set the can_sleep property to true.
>
> This will ensure that a warning is printed when trying to get the
> value from a context that potentially can't sleep.

This deserves a Fixes tag.

--
With Best Regards,
Andy Shevchenko

2023-09-27 17:38:21

by Bartosz Golaszewski

Subject: Re: [PATCH V2 2/2] gpio: pmic-eic-sprd: Add can_sleep flag for PMIC EIC chip

On Thu, Sep 21, 2023 at 5:40 PM Andy Shevchenko <[email protected]> wrote:
>
> On Thu, Sep 21, 2023 at 08:25:27PM +0800, Wenhua Lin wrote:
> > The drivers uses a mutex and I2C bus access in its PMIC EIC chip
> > get implementation. This means these functions can sleep and the PMIC EIC
> > chip should set the can_sleep property to true.
> >
> > This will ensure that a warning is printed when trying to get the
> > value from a context that potentially can't sleep.
>
> This deserves a Fixes tag.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

Added when applying and queued for fixes.

Bart