2023-10-10 03:54:28

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the dmaengine tree

Hi all,

After merging the dmaengine tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/dma/mmp_tdma.c: In function 'mmp_tdma_probe':
drivers/dma/mmp_tdma.c:638:36: error: unused variable 'of_id' [-Werror=unused-variable]
638 | const struct of_device_id *of_id;
| ^~~~~
cc1: all warnings being treated as errors

Caused by commit

a67ba97dfb30 ("dmaengine: Use device_get_match_data()")

I have used the dmaengine tree from next-20231009 for today.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2023-10-10 06:59:36

by Vinod Koul

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the dmaengine tree

On 10-10-23, 14:54, Stephen Rothwell wrote:
> Hi all,
>
> After merging the dmaengine tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/dma/mmp_tdma.c: In function 'mmp_tdma_probe':
> drivers/dma/mmp_tdma.c:638:36: error: unused variable 'of_id' [-Werror=unused-variable]
> 638 | const struct of_device_id *of_id;
> | ^~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> a67ba97dfb30 ("dmaengine: Use device_get_match_data()")
>
> I have used the dmaengine tree from next-20231009 for today.

Thanks for the report, I have posted the fix:
https://lore.kernel.org/dmaengine/[email protected]/

--
~Vinod

2023-10-11 13:42:27

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the dmaengine tree

On Mon, Oct 9, 2023 at 10:54 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the dmaengine tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/dma/mmp_tdma.c: In function 'mmp_tdma_probe':
> drivers/dma/mmp_tdma.c:638:36: error: unused variable 'of_id' [-Werror=unused-variable]
> 638 | const struct of_device_id *of_id;
> | ^~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> a67ba97dfb30 ("dmaengine: Use device_get_match_data()")

FWIW, my patch has the above line removed. Seems it got dropped when applying.

Rob

2023-10-12 12:30:55

by Vinod Koul

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the dmaengine tree

On 11-10-23, 08:41, Rob Herring wrote:
> On Mon, Oct 9, 2023 at 10:54 PM Stephen Rothwell <[email protected]> wrote:
> >
> > Hi all,
> >
> > After merging the dmaengine tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/dma/mmp_tdma.c: In function 'mmp_tdma_probe':
> > drivers/dma/mmp_tdma.c:638:36: error: unused variable 'of_id' [-Werror=unused-variable]
> > 638 | const struct of_device_id *of_id;
> > | ^~~~~
> > cc1: all warnings being treated as errors
> >
> > Caused by commit
> >
> > a67ba97dfb30 ("dmaengine: Use device_get_match_data()")
>
> FWIW, my patch has the above line removed. Seems it got dropped when applying.

Looks like it got missed while applying the patch. The patch had a
conflict so I had to manually apply this one...

Sorry to have missed that

--
~Vinod