2023-10-11 20:07:10

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH v3] pwm: bcm2835: Add support for suspend/resume

Hello Florian,

On Wed, Oct 11, 2023 at 10:07:17AM -0700, Florian Fainelli wrote:
> Similar to other drivers, we need to make sure that the clock is
> disabled during suspend and re-enabled during resume.
>
> Reported-by: Angus Clark <[email protected]>
> Signed-off-by: Florian Fainelli <[email protected]>

Reviewed-by: Uwe Kleine-K?nig <[email protected]>

Thanks for your respin,
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |


Attachments:
(No filename) (593.00 B)
signature.asc (499.00 B)
Download all attachments

2023-10-12 13:55:48

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH v3] pwm: bcm2835: Add support for suspend/resume

On Wed, Oct 11, 2023 at 10:07:17AM -0700, Florian Fainelli wrote:
> Similar to other drivers, we need to make sure that the clock is
> disabled during suspend and re-enabled during resume.
>
> Reported-by: Angus Clark <[email protected]>
> Signed-off-by: Florian Fainelli <[email protected]>
> ---
> Changes in v3:
>
> - removed __maybe_unused and use pm_ptr()
>
> Changes in v2:
>
> - use DEFINE_SIMPLE_DEV_PM_OPS as suggested by Uwe
>
> drivers/pwm/pwm-bcm2835.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)

Applied, thanks.

Thierry