2023-10-12 17:10:21

by Waiman Long

[permalink] [raw]
Subject: [PATCH] cgroup: Fix incorrect css_set_rwsem reference in comment

Since commit f0d9a5f17575 ("cgroup: make css_set_rwsem a spinlock
and rename it to css_set_lock"), css_set_rwsem has been replaced by
css_set_lock. That commit, however, missed the css_set_rwsem reference
in include/linux/cgroup-defs.h. Fix that by changing it to css_set_lock
as well.

Signed-off-by: Waiman Long <[email protected]>
---
include/linux/cgroup-defs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h
index f1b3151ac30b..265da00a1a8b 100644
--- a/include/linux/cgroup-defs.h
+++ b/include/linux/cgroup-defs.h
@@ -238,7 +238,7 @@ struct css_set {
* Lists running through all tasks using this cgroup group.
* mg_tasks lists tasks which belong to this cset but are in the
* process of being migrated out or in. Protected by
- * css_set_rwsem, but, during migration, once tasks are moved to
+ * css_set_lock, but, during migration, once tasks are moved to
* mg_tasks, it can be read safely while holding cgroup_mutex.
*/
struct list_head tasks;
--
2.39.3


2023-10-12 17:36:54

by Tejun Heo

[permalink] [raw]
Subject: Re: [PATCH] cgroup: Fix incorrect css_set_rwsem reference in comment

On Thu, Oct 12, 2023 at 01:09:02PM -0400, Waiman Long wrote:
> Since commit f0d9a5f17575 ("cgroup: make css_set_rwsem a spinlock
> and rename it to css_set_lock"), css_set_rwsem has been replaced by
> css_set_lock. That commit, however, missed the css_set_rwsem reference
> in include/linux/cgroup-defs.h. Fix that by changing it to css_set_lock
> as well.
>
> Signed-off-by: Waiman Long <[email protected]>

Applied to cgroup/for-6.6-fixes.

Thanks.

--
tejun