On Sun, Oct 29, 2023 at 10:09:42AM +0800, Edward Adam Davis wrote:
> There is no lock protection when writing ptp->tsevqs in ptp_open(), ptp_read(),
> ptp_release(), which can cause data corruption and increase mutual exclusion
> to avoid this issue.
-ENOPARSE
How can lack of lock protection increase mutual exclusion?
> Moreover, the queue should not be released in ptp_read() and should be deleted
> together.
The queue should be deleted togther? Huh?
> @@ -543,6 +552,8 @@ ssize_t ptp_read(struct posix_clock_context *pccontext, uint rdflags,
> cnt = EXTTS_BUFSIZE;
>
> cnt = cnt / sizeof(struct ptp_extts_event);
> + if (mutex_lock_interruptible(&ptp->tsevq_mux))
> + return -ERESTARTSYS;
This is not needed because the spin lock (timestamp_event_queue::lock)
already protects the event queue.
Thanks,
Richard