2023-10-10 14:34:25

by Bjorn Helgaas

Subject: [PATCH 0/2] MIPS: lantic: Fix "no prototype" warning

From: Bjorn Helgaas <[email protected]>

Fix a "no prototype" warning found by the kernel test robot.

Bjorn Helgaas (2):
MIPS: lantic: Fix pcibios_plat_dev_init() "no previous prototype"
warning
MIPS: lantic: Remove unnecessary include of <linux/of_irq.h>

arch/mips/pci/fixup-lantiq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--
2.34.1

2023-10-10 14:34:37

by Bjorn Helgaas

Subject: [PATCH 1/2] MIPS: lantic: Fix pcibios_plat_dev_init() "no previous prototype" warning

From: Bjorn Helgaas <[email protected]>

After bbd8810d3998 ("PCI: Remove unused includes and superfluous struct
declaration"), <linux/of_pci.h> no longer includes <linux/pci.h>, which
provides the extern declarations for pcibios_plat_dev_init() and
pcibios_map_irq() via <asm/pci.h>.

This results in these new warnings:

arch/mips/pci/fixup-lantiq.c:13:5: warning: no previous prototype for 'pcibios_plat_dev_init' [-Wmissing-prototypes]
arch/mips/pci/fixup-lantiq.c:24:5: warning: no previous prototype for 'pcibios_map_irq' [-Wmissing-prototypes]

Include <linux/pci.h> directly to get these declarations.

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Bjorn Helgaas <[email protected]>
---
arch/mips/pci/fixup-lantiq.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/mips/pci/fixup-lantiq.c b/arch/mips/pci/fixup-lantiq.c
index 105569c1b712..8f5fb98b3984 100644
--- a/arch/mips/pci/fixup-lantiq.c
+++ b/arch/mips/pci/fixup-lantiq.c
@@ -6,6 +6,7 @@

#include <linux/of_irq.h>
#include <linux/of_pci.h>
+#include <linux/pci.h>

int (*ltq_pci_plat_arch_init)(struct pci_dev *dev) = NULL;
int (*ltq_pci_plat_dev_init)(struct pci_dev *dev) = NULL;
--
2.34.1

2023-10-10 14:34:42

by Bjorn Helgaas

Subject: [PATCH 2/2] MIPS: lantic: Remove unnecessary include of <linux/of_irq.h>

From: Bjorn Helgaas <[email protected]>

arch/mips/pci/fixup-lantiq.c requires nothing from <linux/of_irq.h>, so
remove the include of it.

Signed-off-by: Bjorn Helgaas <[email protected]>
---
arch/mips/pci/fixup-lantiq.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/mips/pci/fixup-lantiq.c b/arch/mips/pci/fixup-lantiq.c
index 8f5fb98b3984..13009666204f 100644
--- a/arch/mips/pci/fixup-lantiq.c
+++ b/arch/mips/pci/fixup-lantiq.c
@@ -4,7 +4,6 @@
* Copyright (C) 2012 John Crispin <[email protected]>
*/

-#include <linux/of_irq.h>
#include <linux/of_pci.h>
#include <linux/pci.h>

--
2.34.1

2023-10-12 08:26:27

by Philippe Mathieu-Daudé

Subject: Re: [PATCH 1/2] MIPS: lantic: Fix pcibios_plat_dev_init() "no previous prototype" warning

On 10/10/23 16:34, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> After bbd8810d3998 ("PCI: Remove unused includes and superfluous struct
> declaration"), <linux/of_pci.h> no longer includes <linux/pci.h>, which
> provides the extern declarations for pcibios_plat_dev_init() and
> pcibios_map_irq() via <asm/pci.h>.
>
> This results in these new warnings:
>
> arch/mips/pci/fixup-lantiq.c:13:5: warning: no previous prototype for 'pcibios_plat_dev_init' [-Wmissing-prototypes]
> arch/mips/pci/fixup-lantiq.c:24:5: warning: no previous prototype for 'pcibios_map_irq' [-Wmissing-prototypes]
>
> Include <linux/pci.h> directly to get these declarations.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Bjorn Helgaas <[email protected]>
> ---
> arch/mips/pci/fixup-lantiq.c | 1 +
> 1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>

2023-10-12 08:27:32

by Philippe Mathieu-Daudé

Subject: Re: [PATCH 2/2] MIPS: lantic: Remove unnecessary include of <linux/of_irq.h>

On 10/10/23 16:34, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> arch/mips/pci/fixup-lantiq.c requires nothing from <linux/of_irq.h>, so
> remove the include of it.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>
> ---
> arch/mips/pci/fixup-lantiq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/pci/fixup-lantiq.c b/arch/mips/pci/fixup-lantiq.c
> index 8f5fb98b3984..13009666204f 100644
> --- a/arch/mips/pci/fixup-lantiq.c
> +++ b/arch/mips/pci/fixup-lantiq.c
> @@ -4,7 +4,6 @@
> * Copyright (C) 2012 John Crispin <[email protected]>
> */
>
> -#include <linux/of_irq.h>
> #include <linux/of_pci.h>

Indeed, we are good with <linux/of_pci.h>.

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>

2023-10-19 08:52:33

by Thomas Bogendoerfer

Subject: Re: [PATCH 0/2] MIPS: lantic: Fix "no prototype" warning

On Tue, Oct 10, 2023 at 09:34:04AM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> Fix a "no prototype" warning found by the kernel test robot.
>
> Bjorn Helgaas (2):
> MIPS: lantic: Fix pcibios_plat_dev_init() "no previous prototype"
> warning
> MIPS: lantic: Remove unnecessary include of <linux/of_irq.h>
>
> arch/mips/pci/fixup-lantiq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

applied to mips-nextr. I've fixed lantic -> lantiq while applying.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]