2023-10-21 22:30:19

by Jules Irenge

[permalink] [raw]
Subject: [PATCH] x86/kprobes: Remove unnecessary extern keyword

Sparse reports a warning at arch_unoptimize_kprobes()

warning: function "arch_unoptimize_kprobes"
with external linkage has definition

The reason is the function is already declared in the header file
as extern

Remove unnecessary "extern" keyword

Signed-off-by: Jules Irenge <[email protected]>
---
arch/x86/kernel/kprobes/opt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c
index 517821b48391..f20ea996abbf 100644
--- a/arch/x86/kernel/kprobes/opt.c
+++ b/arch/x86/kernel/kprobes/opt.c
@@ -526,8 +526,8 @@ void arch_unoptimize_kprobe(struct optimized_kprobe *op)
* Recover original instructions and breakpoints from relative jumps.
* Caller must call with locking kprobe_mutex.
*/
-extern void arch_unoptimize_kprobes(struct list_head *oplist,
- struct list_head *done_list)
+void arch_unoptimize_kprobes(struct list_head *oplist,
+ struct list_head *done_list)
{
struct optimized_kprobe *op, *tmp;

--
2.41.0