2023-11-01 15:35:52

by Lorenzo Bianconi

[permalink] [raw]
Subject: Re: [PATCH 1/1] wifi: mt76: mt7921: Add a new VID/PID 0b48/7922 for MT7922

> PCI VID 0x0b48 doesn't appear to be listed anywhere I can find, though
> a website named pcilookup.com suggests it belongs to TechnoTrend AG. I
> think it's more likely to be part of AMD RZ600 series - rebranded
> mediatek devices. Not sure how any of this might be verified.

I have just found it here: include/linux/pci_ids.h
but I am not sure if it is related. Anyway:

Acked-by: Lorenzo Bianconi <[email protected]>

>
> On Wed, 1 Nov 2023 at 15:00, Lorenzo Bianconi <[email protected]> wrote:
> >
> > > Add VID/PID 0b48/7922 for MediaTek MT7922 wifi chip.
> > > Change tested on Redmi Book Pro 15 2023 (Fedora 38).
> > >
> > > Signed-off-by: Tom Waldron <[email protected]>
> > > ---
> > > drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > > index 3dda84a93..ba805cb02 100644
> > > --- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > > @@ -21,6 +21,8 @@ static const struct pci_device_id mt7921_pci_device_table[] = {
> > > .driver_data = (kernel_ulong_t)MT7921_FIRMWARE_WM },
> > > { PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x0616),
> > > .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
> > > + { PCI_DEVICE(0x0b48, 0x7922),
> > > + .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
> >
> > is PCI VID 0x0b48 PCI_VENDOR_ID_ITTIM?
> >
> > Regards,
> > Lorenzo
> >
> > > { },
> > > };
> > >
> > > --
> > > 2.41.0
> > >


Attachments:
(No filename) (1.63 kB)
signature.asc (235.00 B)
Download all attachments

2023-11-01 15:49:18

by Tom Waldron

[permalink] [raw]
Subject: Re: [PATCH 1/1] wifi: mt76: mt7921: Add a new VID/PID 0b48/7922 for MT7922

Just realised that I had based my changes on the wrong repo(linux
stable). Also that this change has already been made in the
wireless-next repo. It seems the ITTIM vendor was used in this case.

Please ignore this submission and please accept my apologies for
taking up your time.

Regards

Tom

On Wed, 1 Nov 2023 at 15:35, Lorenzo Bianconi <[email protected]> wrote:
>
> > PCI VID 0x0b48 doesn't appear to be listed anywhere I can find, though
> > a website named pcilookup.com suggests it belongs to TechnoTrend AG. I
> > think it's more likely to be part of AMD RZ600 series - rebranded
> > mediatek devices. Not sure how any of this might be verified.
>
> I have just found it here: include/linux/pci_ids.h
> but I am not sure if it is related. Anyway:
>
> Acked-by: Lorenzo Bianconi <[email protected]>
>
> >
> > On Wed, 1 Nov 2023 at 15:00, Lorenzo Bianconi <[email protected]> wrote:
> > >
> > > > Add VID/PID 0b48/7922 for MediaTek MT7922 wifi chip.
> > > > Change tested on Redmi Book Pro 15 2023 (Fedora 38).
> > > >
> > > > Signed-off-by: Tom Waldron <[email protected]>
> > > > ---
> > > > drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > > > index 3dda84a93..ba805cb02 100644
> > > > --- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > > > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > > > @@ -21,6 +21,8 @@ static const struct pci_device_id mt7921_pci_device_table[] = {
> > > > .driver_data = (kernel_ulong_t)MT7921_FIRMWARE_WM },
> > > > { PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x0616),
> > > > .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
> > > > + { PCI_DEVICE(0x0b48, 0x7922),
> > > > + .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
> > >
> > > is PCI VID 0x0b48 PCI_VENDOR_ID_ITTIM?
> > >
> > > Regards,
> > > Lorenzo
> > >
> > > > { },
> > > > };
> > > >
> > > > --
> > > > 2.41.0
> > > >