2023-11-02 09:32:25

by Sudip Mukherjee

[permalink] [raw]
Subject: mainline build failure due to 7966f319c66d ("drm/amd/display: Introduce DML2")

Hi All,

The latest mainline kernel branch fails to build x86_64 allmodconfig
with the error:

drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c: In function 'dml_prefetch_check':
drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6707:1: error: the frame size of 2056 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
6707 | }
| ^

git bisect pointed to 7966f319c66d ("drm/amd/display: Introduce DML2")

I will be happy to test any patch or provide any extra log if needed.

#regzbot introduced: 7966f319c66d9468623c6a6a017ecbc0dd79be75

--
Regards
Sudip


2023-11-02 16:52:54

by Alex Deucher

[permalink] [raw]
Subject: Re: mainline build failure due to 7966f319c66d ("drm/amd/display: Introduce DML2")

On Thu, Nov 2, 2023 at 5:32 AM Sudip Mukherjee (Codethink)
<[email protected]> wrote:
>
> Hi All,
>
> The latest mainline kernel branch fails to build x86_64 allmodconfig
> with the error:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c: In function 'dml_prefetch_check':
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6707:1: error: the frame size of 2056 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> 6707 | }
> | ^
>
> git bisect pointed to 7966f319c66d ("drm/amd/display: Introduce DML2")
>
> I will be happy to test any patch or provide any extra log if needed.

This was reported earlier and fixed by:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=089dbf6a06f1dcaeed4f8b86d619e8d28b235207
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b141fa036c901303ca5659cc22e9c08f8b097892
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5b2c54e0d0ea09f7a3b500510731878326e1117e
but I guess maybe different compiler versions are still hitting this.

Alex

>
> #regzbot introduced: 7966f319c66d9468623c6a6a017ecbc0dd79be75
>
> --
> Regards
> Sudip

2023-11-02 17:08:30

by Sudip Mukherjee

[permalink] [raw]
Subject: Re: mainline build failure due to 7966f319c66d ("drm/amd/display: Introduce DML2")

On Thu, 2 Nov 2023 at 16:52, Alex Deucher <[email protected]> wrote:
>
> On Thu, Nov 2, 2023 at 5:32 AM Sudip Mukherjee (Codethink)
> <[email protected]> wrote:
> >
> > Hi All,
> >
> > The latest mainline kernel branch fails to build x86_64 allmodconfig
> > with the error:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c: In function 'dml_prefetch_check':
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6707:1: error: the frame size of 2056 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> > 6707 | }
> > | ^
> >
> > git bisect pointed to 7966f319c66d ("drm/amd/display: Introduce DML2")
> >
> > I will be happy to test any patch or provide any extra log if needed.
>
> This was reported earlier and fixed by:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=089dbf6a06f1dcaeed4f8b86d619e8d28b235207
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b141fa036c901303ca5659cc22e9c08f8b097892
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5b2c54e0d0ea09f7a3b500510731878326e1117e
> but I guess maybe different compiler versions are still hitting this.

Yes, I should have mentioned. gcc-11 and gcc-12 failed to build. but
gcc-13 was ok.


--
Regards
Sudip

2023-11-02 22:54:20

by Alex Deucher

[permalink] [raw]
Subject: Re: mainline build failure due to 7966f319c66d ("drm/amd/display: Introduce DML2")

On Thu, Nov 2, 2023 at 1:07 PM Sudip Mukherjee
<[email protected]> wrote:
>
> On Thu, 2 Nov 2023 at 16:52, Alex Deucher <[email protected]> wrote:
> >
> > On Thu, Nov 2, 2023 at 5:32 AM Sudip Mukherjee (Codethink)
> > <[email protected]> wrote:
> > >
> > > Hi All,
> > >
> > > The latest mainline kernel branch fails to build x86_64 allmodconfig
> > > with the error:
> > >
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c: In function 'dml_prefetch_check':
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6707:1: error: the frame size of 2056 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> > > 6707 | }
> > > | ^
> > >
> > > git bisect pointed to 7966f319c66d ("drm/amd/display: Introduce DML2")
> > >
> > > I will be happy to test any patch or provide any extra log if needed.
> >
> > This was reported earlier and fixed by:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=089dbf6a06f1dcaeed4f8b86d619e8d28b235207
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b141fa036c901303ca5659cc22e9c08f8b097892
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5b2c54e0d0ea09f7a3b500510731878326e1117e
> > but I guess maybe different compiler versions are still hitting this.
>
> Yes, I should have mentioned. gcc-11 and gcc-12 failed to build. but
> gcc-13 was ok.

Should be fixed with Nathan's patch:
https://patchwork.freedesktop.org/patch/565675/

Alex

2023-11-04 09:43:02

by Sudip Mukherjee

[permalink] [raw]
Subject: Re: mainline build failure due to 7966f319c66d ("drm/amd/display: Introduce DML2")

On Thu, 2 Nov 2023 at 22:53, Alex Deucher <[email protected]> wrote:
>
> On Thu, Nov 2, 2023 at 1:07 PM Sudip Mukherjee
> <[email protected]> wrote:
> >
> > On Thu, 2 Nov 2023 at 16:52, Alex Deucher <[email protected]> wrote:
> > >
> > > On Thu, Nov 2, 2023 at 5:32 AM Sudip Mukherjee (Codethink)
> > > <[email protected]> wrote:
> > > >
> > > > Hi All,
> > > >
> > > > The latest mainline kernel branch fails to build x86_64 allmodconfig
> > > > with the error:
> > > >
> > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c: In function 'dml_prefetch_check':
> > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6707:1: error: the frame size of 2056 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> > > > 6707 | }
> > > > | ^
> > > >
> > > > git bisect pointed to 7966f319c66d ("drm/amd/display: Introduce DML2")
> > > >
> > > > I will be happy to test any patch or provide any extra log if needed.
> > >
> > > This was reported earlier and fixed by:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=089dbf6a06f1dcaeed4f8b86d619e8d28b235207
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b141fa036c901303ca5659cc22e9c08f8b097892
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5b2c54e0d0ea09f7a3b500510731878326e1117e
> > > but I guess maybe different compiler versions are still hitting this.
> >
> > Yes, I should have mentioned. gcc-11 and gcc-12 failed to build. but
> > gcc-13 was ok.
>
> Should be fixed with Nathan's patch:
> https://patchwork.freedesktop.org/patch/565675/

Yes, it does. Thanks.

Tested-by: Sudip Mukherjee <[email protected]>


--
Regards
Sudip