LinuxLists.cc - drivers/media/pci/sta2x11/sta2x11_vip.c:1053:6: warning: cast from 'irqreturn_t (*)(int, struct sta2x11_vip *)' (aka 'enum irqreturn (*)(int, struct sta2x11_vip *)') to 'irq_handler_t' (aka 'enum irqreturn (*)(int, void *)') converts to incompatible funct...

2023-11-06 07:01:42

Subject: drivers/media/pci/sta2x11/sta2x11_vip.c:1053:6: warning: cast from 'irqreturn_t ()(int, struct sta2x11_vip )' (aka 'enum irqreturn ()(int, struct sta2x11_vip )') to 'irq_handler_t' (aka 'enum irqreturn ()(int, void )') converts to incompatible funct...

Hi Arnd,

FYI, the error/warning was bisected to
tree: If you fix the issue in a separate patch/commit the same patch/commit), kindly add following | Reported-by: kernel test robot All warnings (new ones prefixed by >>):
>> drivers/media/pci/sta2x11/sta2x11_vip.c:1053:6: 1053 | (irq_handler_t) | ^~~~~~~~~~~ 1 warning generated.

vim +1053 drivers/media/pci/sta2x11/sta2x11_vip.c
efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 4c62e9764ab403 drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 0bade8b5439520 drivers/media/pci/sta2x11/sta2x11_vip.c 0bade8b5439520 drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 0bade8b5439520 drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 0bade8b5439520 drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 0bade8b5439520 drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c cd63c0288fd760 drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c d017650b40b4cb drivers/media/pci/sta2x11/sta2x11_vip.c d017650b40b4cb drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 4db4ca7450f97c drivers/media/pci/sta2x11/sta2x11_vip.c 4db4ca7450f97c drivers/media/pci/sta2x11/sta2x11_vip.c 4db4ca7450f97c drivers/media/pci/sta2x11/sta2x11_vip.c 4db4ca7450f97c drivers/media/pci/sta2x11/sta2x11_vip.c cd63c0288fd760 drivers/media/pci/sta2x11/sta2x11_vip.c 4db4ca7450f97c drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 3e30a927af3ca8 drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 4db4ca7450f97c drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 11788d9b7e916f drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c
:::::: The code at line 1053 was first :::::: efeb98b4e2b2ce50e008affce4c493e58167144a
:::::: TO: Federico Vaga --
0-DAY CI Kernel Test Service
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
/> media: sta2x11: remove VIRT_TO_BUS dependency
//download.01.org/0day-ci/archive/20231106/202311061401.8TDz7c7d-lkp@intel.com/config)">https://download.01.org/0day-ci/archive/20231106/[email protected]/config)
//github.com/llvm/llvm-project.git">https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
s://download.01.org/0day-ci/archive/20231106/202311061401.8TDz7c7d-lkp@intel.com/reproduce)">https://download.01.org/0day-ci/archive/20231106/[email protected]/reproduce)
(i.e. not just a new version of
tags
gi/l/email-protection#73551f07481f1803331a1d07161f5d101c1e55140748"><[email protected]>
build-all/202311061401.8TDz7c7d-lkp@intel.com/">https://lore.kernel.org/oe-kbuild-all/[email protected]/
/> warning: cast from 'irqreturn_t (*)(int, struct sta2x11_vip *)' (aka 'enum irqreturn (*)(int, struct sta2x11_vip *)') to 'irq_handler_t' (aka 'enum irqreturn (*)(int, void *)') converts to incompatible function type [-Wcast-function-type-strict]
vip_irq,
~~~~~~~~~~~~
/> Federico Vaga 2012-04-12 936
Federico Vaga 2012-04-12 937 /**
Federico Vaga 2012-04-12 938 * sta2x11_vip_init_one - init one instance of video device
Federico Vaga 2012-04-12 939 * @pdev: PCI device
Federico Vaga 2012-04-12 940 * @ent: (not used)
Federico Vaga 2012-04-12 941 *
Federico Vaga 2012-04-12 942 * allocate reset pins for DAC.
Federico Vaga 2012-04-12 943 * Reset video DAC, this is done via reset line.
Federico Vaga 2012-04-12 944 * allocate memory for managing device
Federico Vaga 2012-04-12 945 * request interrupt
Federico Vaga 2012-04-12 946 * map IO region
Federico Vaga 2012-04-12 947 * register device
Federico Vaga 2012-04-12 948 * find and initialize video DAC
Federico Vaga 2012-04-12 949 *
Federico Vaga 2012-04-12 950 * return value: 0, no error
Federico Vaga 2012-04-12 951 *
Federico Vaga 2012-04-12 952 * -ENOMEM, no memory
Federico Vaga 2012-04-12 953 *
Federico Vaga 2012-04-12 954 * -ENODEV, device could not be detected or registered
Federico Vaga 2012-04-12 955 */
Greg Kroah-Hartman 2012-12-21 956 static int sta2x11_vip_init_one(struct pci_dev *pdev,
Federico Vaga 2012-04-12 957 const struct pci_device_id *ent)
Federico Vaga 2012-04-12 958 {
Federico Vaga 2012-04-12 959 int ret;
Federico Vaga 2012-04-12 960 struct sta2x11_vip *vip;
Federico Vaga 2012-04-12 961 struct vip_config *config;
Federico Vaga 2012-04-12 962
Federico Vaga 2013-02-05 963 /* Check if hardware support 26-bit DMA */
Federico Vaga 2013-02-05 964 if (dma_set_mask(&pdev->dev, DMA_BIT_MASK(26))) {
Federico Vaga 2013-02-05 965 dev_err(&pdev->dev, "26-bit DMA addressing not available\n");
Federico Vaga 2013-02-05 966 return -EINVAL;
Federico Vaga 2013-02-05 967 }
Federico Vaga 2013-02-05 968 /* Enable PCI */
Federico Vaga 2012-04-12 969 ret = pci_enable_device(pdev);
Federico Vaga 2012-04-12 970 if (ret)
Federico Vaga 2012-04-12 971 return ret;
Federico Vaga 2012-04-12 972
Federico Vaga 2013-02-05 973 /* Get VIP platform data */
Federico Vaga 2012-04-12 974 config = dev_get_platdata(&pdev->dev);
Federico Vaga 2012-04-12 975 if (!config) {
Federico Vaga 2012-04-12 976 dev_info(&pdev->dev, "VIP slot disabled\n");
Federico Vaga 2012-04-12 977 ret = -EINVAL;
Federico Vaga 2012-04-12 978 goto disable;
Federico Vaga 2012-04-12 979 }
Federico Vaga 2012-04-12 980
Federico Vaga 2013-02-05 981 /* Power configuration */
Federico Vaga 2012-04-12 982 ret = vip_gpio_reserve(&pdev->dev, config->pwr_pin, 0,
Federico Vaga 2012-04-12 983 config->pwr_name);
Federico Vaga 2012-04-12 984 if (ret)
Federico Vaga 2012-04-12 985 goto disable;
Federico Vaga 2012-04-12 986
Federico Vaga 2012-04-12 987 ret = vip_gpio_reserve(&pdev->dev, config->reset_pin, 0,
Federico Vaga 2012-04-12 988 config->reset_name);
Federico Vaga 2012-04-12 989 if (ret) {
Federico Vaga 2012-04-12 990 vip_gpio_release(&pdev->dev, config->pwr_pin,
Federico Vaga 2012-04-12 991 config->pwr_name);
Federico Vaga 2012-04-12 992 goto disable;
Federico Vaga 2012-04-12 993 }
Arvind Yadav 2018-04-27 994
Arvind Yadav 2018-04-27 995 if (gpio_is_valid(config->pwr_pin)) {
Federico Vaga 2012-04-12 996 /* Datasheet says 5ms between PWR and RST */
Federico Vaga 2012-04-12 997 usleep_range(5000, 25000);
Arvind Yadav 2018-04-27 998 gpio_direction_output(config->pwr_pin, 1);
Federico Vaga 2012-04-12 999 }
Federico Vaga 2012-04-12 1000
Arvind Yadav 2018-04-27 1001 if (gpio_is_valid(config->reset_pin)) {
Federico Vaga 2012-04-12 1002 /* Datasheet says 5ms between PWR and RST */
Federico Vaga 2012-04-12 1003 usleep_range(5000, 25000);
Arvind Yadav 2018-04-27 1004 gpio_direction_output(config->reset_pin, 1);
Federico Vaga 2012-04-12 1005 }
Federico Vaga 2012-04-12 1006 usleep_range(5000, 25000);
Federico Vaga 2012-04-12 1007
Federico Vaga 2013-02-05 1008 /* Allocate a new VIP instance */
Federico Vaga 2012-04-12 1009 vip = kzalloc(sizeof(struct sta2x11_vip), GFP_KERNEL);
Federico Vaga 2012-04-12 1010 if (!vip) {
Federico Vaga 2012-04-12 1011 ret = -ENOMEM;
Federico Vaga 2012-04-12 1012 goto release_gpios;
Federico Vaga 2012-04-12 1013 }
Federico Vaga 2012-04-12 1014 vip->pdev = pdev;
Federico Vaga 2012-04-12 1015 vip->std = V4L2_STD_PAL;
Federico Vaga 2012-04-12 1016 vip->format = formats_50[0];
Federico Vaga 2012-04-12 1017 vip->config = config;
Ezequiel Garcia 2018-06-15 1018 mutex_init(&vip->v4l_lock);
Federico Vaga 2012-04-12 1019
Federico Vaga 2013-02-05 1020 ret = sta2x11_vip_init_controls(vip);
Federico Vaga 2013-02-05 1021 if (ret)
Federico Vaga 2013-02-05 1022 goto free_mem;
Wei Yongjun 2013-05-13 1023 ret = v4l2_device_register(&pdev->dev, &vip->v4l2_dev);
Wei Yongjun 2013-05-13 1024 if (ret)
Federico Vaga 2012-04-12 1025 goto free_mem;
Federico Vaga 2012-04-12 1026
Federico Vaga 2012-04-12 1027 dev_dbg(&pdev->dev, "BAR #0 at 0x%lx 0x%lx irq %d\n",
Federico Vaga 2012-04-12 1028 (unsigned long)pci_resource_start(pdev, 0),
Federico Vaga 2012-04-12 1029 (unsigned long)pci_resource_len(pdev, 0), pdev->irq);
Federico Vaga 2012-04-12 1030
Federico Vaga 2012-04-12 1031 pci_set_master(pdev);
Federico Vaga 2012-04-12 1032
Federico Vaga 2013-02-05 1033 ret = pci_request_regions(pdev, KBUILD_MODNAME);
Federico Vaga 2012-04-12 1034 if (ret)
Federico Vaga 2012-04-12 1035 goto unreg;
Federico Vaga 2012-04-12 1036
Federico Vaga 2012-04-12 1037 vip->iomem = pci_iomap(pdev, 0, 0x100);
Federico Vaga 2012-04-12 1038 if (!vip->iomem) {
Federico Vaga 2013-02-05 1039 ret = -ENOMEM;
Federico Vaga 2012-04-12 1040 goto release;
Federico Vaga 2012-04-12 1041 }
Federico Vaga 2012-04-12 1042
Federico Vaga 2012-04-12 1043 pci_enable_msi(pdev);
Federico Vaga 2012-04-12 1044
Federico Vaga 2013-02-05 1045 /* Initialize buffer */
Federico Vaga 2013-02-05 1046 ret = sta2x11_vip_init_buffer(vip);
Federico Vaga 2013-02-05 1047 if (ret)
Federico Vaga 2013-02-05 1048 goto unmap;
Federico Vaga 2013-02-05 1049
Federico Vaga 2012-04-12 1050 spin_lock_init(&vip->slock);
Federico Vaga 2012-04-12 1051
Federico Vaga 2012-04-12 1052 ret = request_irq(pdev->irq,
Federico Vaga 2012-04-12 @1053 (irq_handler_t) vip_irq,
Federico Vaga 2013-02-05 1054 IRQF_SHARED, KBUILD_MODNAME, vip);
Federico Vaga 2012-04-12 1055 if (ret) {
Federico Vaga 2012-04-12 1056 dev_err(&pdev->dev, "request_irq failed\n");
Federico Vaga 2012-04-12 1057 ret = -ENODEV;
Federico Vaga 2013-02-05 1058 goto release_buf;
Federico Vaga 2012-04-12 1059 }
Federico Vaga 2012-04-12 1060
Hans Verkuil 2015-03-09 1061 /* Initialize and register video device */
Hans Verkuil 2015-03-09 1062 vip->video_dev = video_dev_template;
Hans Verkuil 2015-03-09 1063 vip->video_dev.v4l2_dev = &vip->v4l2_dev;
Hans Verkuil 2015-03-09 1064 vip->video_dev.queue = &vip->vb_vidq;
Ezequiel Garcia 2018-06-15 1065 vip->video_dev.lock = &vip->v4l_lock;
Hans Verkuil 2015-03-09 1066 video_set_drvdata(&vip->video_dev, vip);
Federico Vaga 2012-04-12 1067
Hans Verkuil 2020-02-03 1068 ret = video_register_device(&vip->video_dev, VFL_TYPE_VIDEO, -1);
Federico Vaga 2012-04-12 1069 if (ret)
Federico Vaga 2012-04-12 1070 goto vrelease;
Federico Vaga 2012-04-12 1071
Federico Vaga 2013-02-05 1072 /* Get ADV7180 subdevice */
Federico Vaga 2012-04-12 1073 vip->adapter = i2c_get_adapter(vip->config->i2c_id);
Federico Vaga 2012-04-12 1074 if (!vip->adapter) {
Federico Vaga 2012-04-12 1075 ret = -ENODEV;
Federico Vaga 2012-04-12 1076 dev_err(&pdev->dev, "no I2C adapter found\n");
Federico Vaga 2012-04-12 1077 goto vunreg;
Federico Vaga 2012-04-12 1078 }
Federico Vaga 2012-04-12 1079
Federico Vaga 2012-04-12 1080 vip->decoder = v4l2_i2c_new_subdev(&vip->v4l2_dev, vip->adapter,
Federico Vaga 2012-04-12 1081 "adv7180", vip->config->i2c_addr,
Federico Vaga 2012-04-12 1082 NULL);
Federico Vaga 2012-04-12 1083 if (!vip->decoder) {
Federico Vaga 2012-04-12 1084 ret = -ENODEV;
Federico Vaga 2012-04-12 1085 dev_err(&pdev->dev, "no decoder found\n");
Federico Vaga 2012-04-12 1086 goto vunreg;
Federico Vaga 2012-04-12 1087 }
Federico Vaga 2012-04-12 1088
Federico Vaga 2012-04-12 1089 i2c_put_adapter(vip->adapter);
Federico Vaga 2012-04-12 1090 v4l2_subdev_call(vip->decoder, core, init, 0);
Federico Vaga 2012-04-12 1091
Federico Vaga 2013-02-05 1092 sta2x11_vip_init_register(vip);
Federico Vaga 2013-02-05 1093
Federico Vaga 2013-02-05 1094 dev_info(&pdev->dev, "STA2X11 Video Input Port (VIP) loaded\n");
Federico Vaga 2012-04-12 1095 return 0;
Federico Vaga 2012-04-12 1096
Federico Vaga 2012-04-12 1097 vunreg:
Hans Verkuil 2015-03-09 1098 video_set_drvdata(&vip->video_dev, NULL);
Federico Vaga 2012-04-12 1099 vrelease:
Hans Verkuil 2020-07-13 1100 vb2_video_unregister_device(&vip->video_dev);
Federico Vaga 2012-04-12 1101 free_irq(pdev->irq, vip);
Federico Vaga 2013-02-05 1102 release_buf:
Federico Vaga 2012-04-12 1103 pci_disable_msi(pdev);
Federico Vaga 2012-04-12 1104 unmap:
Federico Vaga 2012-04-12 1105 pci_iounmap(pdev, vip->iomem);
Federico Vaga 2012-04-12 1106 release:
Federico Vaga 2012-04-12 1107 pci_release_regions(pdev);
Federico Vaga 2012-04-12 1108 unreg:
Federico Vaga 2012-04-12 1109 v4l2_device_unregister(&vip->v4l2_dev);
Federico Vaga 2012-04-12 1110 free_mem:
Federico Vaga 2012-04-12 1111 kfree(vip);
Federico Vaga 2012-04-12 1112 release_gpios:
Federico Vaga 2012-04-12 1113 vip_gpio_release(&pdev->dev, config->reset_pin, config->reset_name);
Federico Vaga 2012-04-12 1114 vip_gpio_release(&pdev->dev, config->pwr_pin, config->pwr_name);
Federico Vaga 2012-04-12 1115 disable:
Federico Vaga 2012-04-12 1116 /*
Federico Vaga 2012-04-12 1117 * do not call pci_disable_device on sta2x11 because it break all
Federico Vaga 2012-04-12 1118 * other Bus masters on this EP
Federico Vaga 2012-04-12 1119 */
Federico Vaga 2012-04-12 1120 return ret;
Federico Vaga 2012-04-12 1121 }
Federico Vaga 2012-04-12 1122
introduced by commit
[media] STA2X11 VIP: new V4L2 driver
il-protection#0c2a6078376a6968697e656f63227a6d6b6d4c6b616d6560226f63612a6b7837"><[email protected]>
gi/l/email-protection#597f352d62343a313c31383b192b3c3d31382d773a36347f3e2d62"><[email protected]>
i">https://github.com/intel/lkp-tests/wiki

2023-11-06 07:25:43

by Li, Philip

[permalink] [raw]

Subject: Re: drivers/media/pci/sta2x11/sta2x11_vip.c:1053:6: warning: cast from 'irqreturn_t ()(int, struct sta2x11_vip )' (aka 'enum irqreturn ()(int, struct sta2x11_vip )') to 'irq_handler_t' (aka 'enum irqreturn ()(int, void )') converts to incompatible funct...

On Mon, Nov 06, 2023 at 02:59:24PM +0800, kernel test robot wrote:
> Hi Arnd,
>
> FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.

Sorry Arnd for this false report, kindly ignore it as it is not
the initial cause of the warning.

>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: d2f51b3516dade79269ff45eae2a7668ae711b25
> commit: a157802359f7451ed8046b2b6dbaca187797e062 media: sta2x11: remove VIRT_TO_BUS dependency
> date: 1 year, 4 months ago
> config: powerpc64-allyesconfig (https://download.01.org/0day-ci/archive/20231106/[email protected]/config)
> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231106/[email protected]/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <[email protected]>
> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/media/pci/sta2x11/sta2x11_vip.c:1053:6: warning: cast from 'irqreturn_t (*)(int, struct sta2x11_vip *)' (aka 'enum irqreturn (*)(int, struct sta2x11_vip *)') to 'irq_handler_t' (aka 'enum irqreturn (*)(int, void *)') converts to incompatible function type [-Wcast-function-type-strict]
> 1053 | (irq_handler_t) vip_irq,
> | ^~~~~~~~~~~~~~~~~~~~~~~
> 1 warning generated.
>
>
> vim +1053 drivers/media/pci/sta2x11/sta2x11_vip.c
>
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 936
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 937 /**
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 938 * sta2x11_vip_init_one - init one instance of video device
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 939 * @pdev: PCI device
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 940 * @ent: (not used)
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 941 *
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 942 * allocate reset pins for DAC.
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 943 * Reset video DAC, this is done via reset line.
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 944 * allocate memory for managing device
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 945 * request interrupt
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 946 * map IO region
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 947 * register device
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 948 * find and initialize video DAC
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 949 *
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 950 * return value: 0, no error
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 951 *
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 952 * -ENOMEM, no memory
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 953 *
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 954 * -ENODEV, device could not be detected or registered
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 955 */
> 4c62e9764ab403 drivers/media/pci/sta2x11/sta2x11_vip.c Greg Kroah-Hartman 2012-12-21 956 static int sta2x11_vip_init_one(struct pci_dev *pdev,
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 957 const struct pci_device_id *ent)
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 958 {
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 959 int ret;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 960 struct sta2x11_vip *vip;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 961 struct vip_config *config;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 962
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 963 /* Check if hardware support 26-bit DMA */
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 964 if (dma_set_mask(&pdev->dev, DMA_BIT_MASK(26))) {
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 965 dev_err(&pdev->dev, "26-bit DMA addressing not available\n");
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 966 return -EINVAL;
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 967 }
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 968 /* Enable PCI */
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 969 ret = pci_enable_device(pdev);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 970 if (ret)
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 971 return ret;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 972
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 973 /* Get VIP platform data */
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 974 config = dev_get_platdata(&pdev->dev);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 975 if (!config) {
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 976 dev_info(&pdev->dev, "VIP slot disabled\n");
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 977 ret = -EINVAL;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 978 goto disable;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 979 }
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 980
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 981 /* Power configuration */
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 982 ret = vip_gpio_reserve(&pdev->dev, config->pwr_pin, 0,
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 983 config->pwr_name);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 984 if (ret)
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 985 goto disable;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 986
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 987 ret = vip_gpio_reserve(&pdev->dev, config->reset_pin, 0,
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 988 config->reset_name);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 989 if (ret) {
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 990 vip_gpio_release(&pdev->dev, config->pwr_pin,
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 991 config->pwr_name);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 992 goto disable;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 993 }
> 0bade8b5439520 drivers/media/pci/sta2x11/sta2x11_vip.c Arvind Yadav 2018-04-27 994
> 0bade8b5439520 drivers/media/pci/sta2x11/sta2x11_vip.c Arvind Yadav 2018-04-27 995 if (gpio_is_valid(config->pwr_pin)) {
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 996 /* Datasheet says 5ms between PWR and RST */
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 997 usleep_range(5000, 25000);
> 0bade8b5439520 drivers/media/pci/sta2x11/sta2x11_vip.c Arvind Yadav 2018-04-27 998 gpio_direction_output(config->pwr_pin, 1);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 999 }
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1000
> 0bade8b5439520 drivers/media/pci/sta2x11/sta2x11_vip.c Arvind Yadav 2018-04-27 1001 if (gpio_is_valid(config->reset_pin)) {
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1002 /* Datasheet says 5ms between PWR and RST */
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1003 usleep_range(5000, 25000);
> 0bade8b5439520 drivers/media/pci/sta2x11/sta2x11_vip.c Arvind Yadav 2018-04-27 1004 gpio_direction_output(config->reset_pin, 1);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1005 }
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1006 usleep_range(5000, 25000);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1007
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1008 /* Allocate a new VIP instance */
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1009 vip = kzalloc(sizeof(struct sta2x11_vip), GFP_KERNEL);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1010 if (!vip) {
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1011 ret = -ENOMEM;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1012 goto release_gpios;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1013 }
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1014 vip->pdev = pdev;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1015 vip->std = V4L2_STD_PAL;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1016 vip->format = formats_50[0];
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1017 vip->config = config;
> cd63c0288fd760 drivers/media/pci/sta2x11/sta2x11_vip.c Ezequiel Garcia 2018-06-15 1018 mutex_init(&vip->v4l_lock);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1019
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1020 ret = sta2x11_vip_init_controls(vip);
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1021 if (ret)
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1022 goto free_mem;
> d017650b40b4cb drivers/media/pci/sta2x11/sta2x11_vip.c Wei Yongjun 2013-05-13 1023 ret = v4l2_device_register(&pdev->dev, &vip->v4l2_dev);
> d017650b40b4cb drivers/media/pci/sta2x11/sta2x11_vip.c Wei Yongjun 2013-05-13 1024 if (ret)
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1025 goto free_mem;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1026
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1027 dev_dbg(&pdev->dev, "BAR #0 at 0x%lx 0x%lx irq %d\n",
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1028 (unsigned long)pci_resource_start(pdev, 0),
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1029 (unsigned long)pci_resource_len(pdev, 0), pdev->irq);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1030
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1031 pci_set_master(pdev);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1032
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1033 ret = pci_request_regions(pdev, KBUILD_MODNAME);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1034 if (ret)
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1035 goto unreg;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1036
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1037 vip->iomem = pci_iomap(pdev, 0, 0x100);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1038 if (!vip->iomem) {
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1039 ret = -ENOMEM;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1040 goto release;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1041 }
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1042
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1043 pci_enable_msi(pdev);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1044
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1045 /* Initialize buffer */
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1046 ret = sta2x11_vip_init_buffer(vip);
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1047 if (ret)
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1048 goto unmap;
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1049
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1050 spin_lock_init(&vip->slock);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1051
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1052 ret = request_irq(pdev->irq,
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 @1053 (irq_handler_t) vip_irq,
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1054 IRQF_SHARED, KBUILD_MODNAME, vip);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1055 if (ret) {
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1056 dev_err(&pdev->dev, "request_irq failed\n");
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1057 ret = -ENODEV;
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1058 goto release_buf;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1059 }
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1060
> 4db4ca7450f97c drivers/media/pci/sta2x11/sta2x11_vip.c Hans Verkuil 2015-03-09 1061 /* Initialize and register video device */
> 4db4ca7450f97c drivers/media/pci/sta2x11/sta2x11_vip.c Hans Verkuil 2015-03-09 1062 vip->video_dev = video_dev_template;
> 4db4ca7450f97c drivers/media/pci/sta2x11/sta2x11_vip.c Hans Verkuil 2015-03-09 1063 vip->video_dev.v4l2_dev = &vip->v4l2_dev;
> 4db4ca7450f97c drivers/media/pci/sta2x11/sta2x11_vip.c Hans Verkuil 2015-03-09 1064 vip->video_dev.queue = &vip->vb_vidq;
> cd63c0288fd760 drivers/media/pci/sta2x11/sta2x11_vip.c Ezequiel Garcia 2018-06-15 1065 vip->video_dev.lock = &vip->v4l_lock;
> 4db4ca7450f97c drivers/media/pci/sta2x11/sta2x11_vip.c Hans Verkuil 2015-03-09 1066 video_set_drvdata(&vip->video_dev, vip);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1067
> 3e30a927af3ca8 drivers/media/pci/sta2x11/sta2x11_vip.c Hans Verkuil 2020-02-03 1068 ret = video_register_device(&vip->video_dev, VFL_TYPE_VIDEO, -1);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1069 if (ret)
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1070 goto vrelease;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1071
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1072 /* Get ADV7180 subdevice */
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1073 vip->adapter = i2c_get_adapter(vip->config->i2c_id);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1074 if (!vip->adapter) {
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1075 ret = -ENODEV;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1076 dev_err(&pdev->dev, "no I2C adapter found\n");
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1077 goto vunreg;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1078 }
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1079
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1080 vip->decoder = v4l2_i2c_new_subdev(&vip->v4l2_dev, vip->adapter,
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1081 "adv7180", vip->config->i2c_addr,
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1082 NULL);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1083 if (!vip->decoder) {
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1084 ret = -ENODEV;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1085 dev_err(&pdev->dev, "no decoder found\n");
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1086 goto vunreg;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1087 }
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1088
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1089 i2c_put_adapter(vip->adapter);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1090 v4l2_subdev_call(vip->decoder, core, init, 0);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1091
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1092 sta2x11_vip_init_register(vip);
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1093
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1094 dev_info(&pdev->dev, "STA2X11 Video Input Port (VIP) loaded\n");
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1095 return 0;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1096
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1097 vunreg:
> 4db4ca7450f97c drivers/media/pci/sta2x11/sta2x11_vip.c Hans Verkuil 2015-03-09 1098 video_set_drvdata(&vip->video_dev, NULL);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1099 vrelease:
> 11788d9b7e916f drivers/media/pci/sta2x11/sta2x11_vip.c Hans Verkuil 2020-07-13 1100 vb2_video_unregister_device(&vip->video_dev);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1101 free_irq(pdev->irq, vip);
> 8dc97ea20c2bdf drivers/media/pci/sta2x11/sta2x11_vip.c Federico Vaga 2013-02-05 1102 release_buf:
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1103 pci_disable_msi(pdev);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1104 unmap:
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1105 pci_iounmap(pdev, vip->iomem);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1106 release:
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1107 pci_release_regions(pdev);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1108 unreg:
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1109 v4l2_device_unregister(&vip->v4l2_dev);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1110 free_mem:
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1111 kfree(vip);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1112 release_gpios:
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1113 vip_gpio_release(&pdev->dev, config->reset_pin, config->reset_name);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1114 vip_gpio_release(&pdev->dev, config->pwr_pin, config->pwr_name);
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1115 disable:
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1116 /*
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1117 * do not call pci_disable_device on sta2x11 because it break all
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1118 * other Bus masters on this EP
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1119 */
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1120 return ret;
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1121 }
> efeb98b4e2b2ce drivers/media/video/sta2x11_vip.c Federico Vaga 2012-04-12 1122
>
> :::::: The code at line 1053 was first introduced by commit
> :::::: efeb98b4e2b2ce50e008affce4c493e58167144a [media] STA2X11 VIP: new V4L2 driver
>
> :::::: TO: Federico Vaga <[email protected]>
> :::::: CC: Mauro Carvalho Chehab <[email protected]>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

Subject: drivers/media/pci/sta2x11/sta2x11_vip.c:1053:6: warning: cast from 'irqreturn_t (*)(int, struct sta2x11_vip *)' (aka 'enum irqreturn (*)(int, struct sta2x11_vip *)') to 'irq_handler_t' (aka 'enum irqreturn (*)(int, void *)') converts to incompatible funct...

Subject: Re: drivers/media/pci/sta2x11/sta2x11_vip.c:1053:6: warning: cast from 'irqreturn_t (*)(int, struct sta2x11_vip *)' (aka 'enum irqreturn (*)(int, struct sta2x11_vip *)') to 'irq_handler_t' (aka 'enum irqreturn (*)(int, void *)') converts to incompatible funct...

Subject: drivers/media/pci/sta2x11/sta2x11_vip.c:1053:6: warning: cast from 'irqreturn_t ()(int, struct sta2x11_vip )' (aka 'enum irqreturn ()(int, struct sta2x11_vip )') to 'irq_handler_t' (aka 'enum irqreturn ()(int, void )') converts to incompatible funct...

Subject: Re: drivers/media/pci/sta2x11/sta2x11_vip.c:1053:6: warning: cast from 'irqreturn_t ()(int, struct sta2x11_vip )' (aka 'enum irqreturn ()(int, struct sta2x11_vip )') to 'irq_handler_t' (aka 'enum irqreturn ()(int, void )') converts to incompatible funct...