After removal of the legacy eeprom driver the only remaining I2C
client device driver supporting I2C_CLASS_SPD is jc42. Because this
driver also supports I2C_CLASS_HWMON, adapters don't have to
declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
It's one step towards getting rid of I2C_CLASS_SPD mid-term.
Series was created supported by Coccinelle and its splitpatch.
Signed-off-by: Heiner Kallweit <[email protected]>
---
drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
index bd38ce444..46676f2c8 100644
--- a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
+++ b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
@@ -289,7 +289,7 @@ static const struct i2c_algorithm netup_i2c_algorithm = {
static const struct i2c_adapter netup_i2c_adapter = {
.owner = THIS_MODULE,
.name = NETUP_UNIDVB_NAME,
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.algo = &netup_i2c_algorithm,
};
On Sat, Nov 18, 2023 at 07:05:02PM +0100, Heiner Kallweit wrote:
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>
> Series was created supported by Coccinelle and its splitpatch.
>
> Signed-off-by: Heiner Kallweit <[email protected]>
As I want to apply this cleanup early in the cycle, could we have an ack
for me to modify this subsystem, please?
>
> ---
> drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
> index bd38ce444..46676f2c8 100644
> --- a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
> +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
> @@ -289,7 +289,7 @@ static const struct i2c_algorithm netup_i2c_algorithm = {
> static const struct i2c_adapter netup_i2c_adapter = {
> .owner = THIS_MODULE,
> .name = NETUP_UNIDVB_NAME,
> - .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
> + .class = I2C_CLASS_HWMON,
> .algo = &netup_i2c_algorithm,
> };
>
>
On 23.11.2023 21:55, Wolfram Sang wrote:
> On Sat, Nov 18, 2023 at 07:05:02PM +0100, Heiner Kallweit wrote:
>> After removal of the legacy eeprom driver the only remaining I2C
>> client device driver supporting I2C_CLASS_SPD is jc42. Because this
>> driver also supports I2C_CLASS_HWMON, adapters don't have to
>> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
>> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>>
>> Series was created supported by Coccinelle and its splitpatch.
>>
>> Signed-off-by: Heiner Kallweit <[email protected]>
>
> As I want to apply this cleanup early in the cycle, could we have an ack
> for me to modify this subsystem, please?
>
Looking at the git history for this driver, there has been no sign of
life from the official maintainers for years. Hopefully Mauro can ack this.
>>
>> ---
>> drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
>> index bd38ce444..46676f2c8 100644
>> --- a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
>> +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
>> @@ -289,7 +289,7 @@ static const struct i2c_algorithm netup_i2c_algorithm = {
>> static const struct i2c_adapter netup_i2c_adapter = {
>> .owner = THIS_MODULE,
>> .name = NETUP_UNIDVB_NAME,
>> - .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
>> + .class = I2C_CLASS_HWMON,
>> .algo = &netup_i2c_algorithm,
>> };
>>
>>