2023-11-20 23:41:17

by kernel test robot

Subject: drivers/media/rc/ttusbir.c:1: warning: no structured comments found

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 98b1cc82c4affc16f5598d4fa14b1858671b2263
commit: b9e1486e0e4b5e0fc0cde214ceecec8a5734f620 media: rc-core: do not depend on MEDIA_SUPPORT
date: 6 years ago
config: i386-randconfig-005-20231120 (https://download.01.org/0day-ci/archive/20231121/[email protected]/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231121/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

>> drivers/media/rc/ttusbir.c:1: warning: no structured comments found


vim +1 drivers/media/rc/ttusbir.c

0938069fa08970 Sean Young 2012-08-13 @1 /*
0938069fa08970 Sean Young 2012-08-13 2 * TechnoTrend USB IR Receiver
0938069fa08970 Sean Young 2012-08-13 3 *
0938069fa08970 Sean Young 2012-08-13 4 * Copyright (C) 2012 Sean Young <[email protected]>
0938069fa08970 Sean Young 2012-08-13 5 *
0938069fa08970 Sean Young 2012-08-13 6 * This program is free software; you can redistribute it and/or modify
0938069fa08970 Sean Young 2012-08-13 7 * it under the terms of the GNU General Public License as published by
0938069fa08970 Sean Young 2012-08-13 8 * the Free Software Foundation; either version 2 of the License, or
0938069fa08970 Sean Young 2012-08-13 9 * (at your option) any later version.
0938069fa08970 Sean Young 2012-08-13 10 *
0938069fa08970 Sean Young 2012-08-13 11 * This program is distributed in the hope that it will be useful,
0938069fa08970 Sean Young 2012-08-13 12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
0938069fa08970 Sean Young 2012-08-13 13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
0938069fa08970 Sean Young 2012-08-13 14 * GNU General Public License for more details.
0938069fa08970 Sean Young 2012-08-13 15 */
0938069fa08970 Sean Young 2012-08-13 16

:::::: The code at line 1 was first introduced by commit
:::::: 0938069fa08970f1c898970c1331a029efe9a1ce [media] rc: Add support for the TechnoTrend USB IR Receiver

:::::: TO: Sean Young <[email protected]>
:::::: CC: Mauro Carvalho Chehab <[email protected]>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

2023-11-21 08:49:31

by Sean Young

Subject: Re: drivers/media/rc/ttusbir.c:1: warning: no structured comments found

On Tue, Nov 21, 2023 at 07:39:58AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 98b1cc82c4affc16f5598d4fa14b1858671b2263
> commit: b9e1486e0e4b5e0fc0cde214ceecec8a5734f620 media: rc-core: do not depend on MEDIA_SUPPORT
> date: 6 years ago

A bug report on a 6 year old commit? This is nowhere near current master.

> config: i386-randconfig-005-20231120 (https://download.01.org/0day-ci/archive/20231121/[email protected]/config)
> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231121/[email protected]/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <[email protected]>
> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/media/rc/ttusbir.c:1: warning: no structured comments found

What does that mean? Not a helpful warning message.

> vim +1 drivers/media/rc/ttusbir.c
>
> 0938069fa08970 Sean Young 2012-08-13 @1 /*
> 0938069fa08970 Sean Young 2012-08-13 2 * TechnoTrend USB IR Receiver
> 0938069fa08970 Sean Young 2012-08-13 3 *
> 0938069fa08970 Sean Young 2012-08-13 4 * Copyright (C) 2012 Sean Young <[email protected]>
> 0938069fa08970 Sean Young 2012-08-13 5 *
> 0938069fa08970 Sean Young 2012-08-13 6 * This program is free software; you can redistribute it and/or modify
> 0938069fa08970 Sean Young 2012-08-13 7 * it under the terms of the GNU General Public License as published by
> 0938069fa08970 Sean Young 2012-08-13 8 * the Free Software Foundation; either version 2 of the License, or
> 0938069fa08970 Sean Young 2012-08-13 9 * (at your option) any later version.
> 0938069fa08970 Sean Young 2012-08-13 10 *
> 0938069fa08970 Sean Young 2012-08-13 11 * This program is distributed in the hope that it will be useful,
> 0938069fa08970 Sean Young 2012-08-13 12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
> 0938069fa08970 Sean Young 2012-08-13 13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> 0938069fa08970 Sean Young 2012-08-13 14 * GNU General Public License for more details.
> 0938069fa08970 Sean Young 2012-08-13 15 */
> 0938069fa08970 Sean Young 2012-08-13 16

Like I said, that is pretty ancient code.


Sean

>
> :::::: The code at line 1 was first introduced by commit
> :::::: 0938069fa08970f1c898970c1331a029efe9a1ce [media] rc: Add support for the TechnoTrend USB IR Receiver
>
> :::::: TO: Sean Young <[email protected]>
> :::::: CC: Mauro Carvalho Chehab <[email protected]>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

2023-11-22 02:04:11

by Yujie Liu

Subject: Re: drivers/media/rc/ttusbir.c:1: warning: no structured comments found

On Tue, Nov 21, 2023 at 08:49:07AM +0000, Sean Young wrote:
> On Tue, Nov 21, 2023 at 07:39:58AM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: 98b1cc82c4affc16f5598d4fa14b1858671b2263
> > commit: b9e1486e0e4b5e0fc0cde214ceecec8a5734f620 media: rc-core: do not depend on MEDIA_SUPPORT
> > date: 6 years ago
>
> A bug report on a 6 year old commit? This is nowhere near current master.
>
> > config: i386-randconfig-005-20231120 (https://download.01.org/0day-ci/archive/20231121/[email protected]/config)
> > compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231121/[email protected]/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <[email protected]>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> drivers/media/rc/ttusbir.c:1: warning: no structured comments found
>
> What does that mean? Not a helpful warning message.

We've configured the bot the ignore this warning. Sorry for the noise.

Thanks,
Yujie

> > vim +1 drivers/media/rc/ttusbir.c
> >
> > 0938069fa08970 Sean Young 2012-08-13 @1 /*
> > 0938069fa08970 Sean Young 2012-08-13 2 * TechnoTrend USB IR Receiver
> > 0938069fa08970 Sean Young 2012-08-13 3 *
> > 0938069fa08970 Sean Young 2012-08-13 4 * Copyright (C) 2012 Sean Young <[email protected]>
> > 0938069fa08970 Sean Young 2012-08-13 5 *
> > 0938069fa08970 Sean Young 2012-08-13 6 * This program is free software; you can redistribute it and/or modify
> > 0938069fa08970 Sean Young 2012-08-13 7 * it under the terms of the GNU General Public License as published by
> > 0938069fa08970 Sean Young 2012-08-13 8 * the Free Software Foundation; either version 2 of the License, or
> > 0938069fa08970 Sean Young 2012-08-13 9 * (at your option) any later version.
> > 0938069fa08970 Sean Young 2012-08-13 10 *
> > 0938069fa08970 Sean Young 2012-08-13 11 * This program is distributed in the hope that it will be useful,
> > 0938069fa08970 Sean Young 2012-08-13 12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > 0938069fa08970 Sean Young 2012-08-13 13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > 0938069fa08970 Sean Young 2012-08-13 14 * GNU General Public License for more details.
> > 0938069fa08970 Sean Young 2012-08-13 15 */
> > 0938069fa08970 Sean Young 2012-08-13 16
>
> Like I said, that is pretty ancient code.
>
>
> Sean
>
> >
> > :::::: The code at line 1 was first introduced by commit
> > :::::: 0938069fa08970f1c898970c1331a029efe9a1ce [media] rc: Add support for the TechnoTrend USB IR Receiver
> >
> > :::::: TO: Sean Young <[email protected]>
> > :::::: CC: Mauro Carvalho Chehab <[email protected]>
> >
> > --
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
>