Hi Johan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus linus/master v6.7-rc1 next-20231115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Johan-Hovold/PCI-ASPM-Add-locked-helper-for-enabling-link-state/20231114-220117
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link: https://lore.kernel.org/r/20231114135553.32301-2-johan%2Blinaro%40kernel.org
patch subject: [PATCH 1/6] PCI/ASPM: Add locked helper for enabling link state
config: x86_64-randconfig-002-20231115 (https://download.01.org/0day-ci/archive/20231115/[email protected]/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231115/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
>> drivers/pci/pcie/aspm.c:1186: warning: expecting prototype for pci_enable_link_state(). Prototype was for pci_enable_link_state_locked() instead
vim +1186 drivers/pci/pcie/aspm.c
1172
1173 /**
1174 * pci_enable_link_state - Clear and set the default device link state so that
1175 * the link may be allowed to enter the specified states. Note that if the
1176 * BIOS didn't grant ASPM control to the OS, this does nothing because we can't
1177 * touch the LNKCTL register. Also note that this does not enable states
1178 * disabled by pci_disable_link_state(). Return 0 or a negative errno.
1179 *
1180 * @pdev: PCI device
1181 * @state: Mask of ASPM link states to enable
1182 *
1183 * Context: Caller holds pci_bus_sem read lock.
1184 */
1185 int pci_enable_link_state_locked(struct pci_dev *pdev, int state)
> 1186 {
1187 lockdep_assert_held_read(&pci_bus_sem);
1188
1189 return __pci_enable_link_state(pdev, state, true);
1190 }
1191 EXPORT_SYMBOL(pci_enable_link_state_locked);
1192
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
On Wed, Nov 15, 2023 at 10:26:40PM +0800, kernel test robot wrote:
> >> drivers/pci/pcie/aspm.c:1186: warning: expecting prototype for pci_enable_link_state(). Prototype was for pci_enable_link_state_locked() instead
>
>
> vim +1186 drivers/pci/pcie/aspm.c
>
> 1172
> 1173 /**
> 1174 * pci_enable_link_state - Clear and set the default device link state so that
I apparently forgot to update the name here to
pci_enable_link_state_locked
[ ... ]
> 1184 */
> 1185 int pci_enable_link_state_locked(struct pci_dev *pdev, int state)
Perhaps this can be fixed up when applying, or otherwise I'll respin.
Johan
On Wed, Nov 15, 2023 at 05:06:23PM +0100, Johan Hovold wrote:
> On Wed, Nov 15, 2023 at 10:26:40PM +0800, kernel test robot wrote:
>
> > >> drivers/pci/pcie/aspm.c:1186: warning: expecting prototype for pci_enable_link_state(). Prototype was for pci_enable_link_state_locked() instead
> >
> >
> > vim +1186 drivers/pci/pcie/aspm.c
> >
> > 1172
> > 1173 /**
> > 1174 * pci_enable_link_state - Clear and set the default device link state so that
>
> I apparently forgot to update the name here to
>
> pci_enable_link_state_locked
>
While fixing the name, please add locking information in description as well.
- Mani
> [ ... ]
>
> > 1184 */
> > 1185 int pci_enable_link_state_locked(struct pci_dev *pdev, int state)
>
> Perhaps this can be fixed up when applying, or otherwise I'll respin.
>
> Johan
--
மணிவண்ணன் சதாசிவம்
On Fri, Nov 17, 2023 at 03:57:24PM +0530, Manivannan Sadhasivam wrote:
> On Wed, Nov 15, 2023 at 05:06:23PM +0100, Johan Hovold wrote:
> > On Wed, Nov 15, 2023 at 10:26:40PM +0800, kernel test robot wrote:
> >
> > > >> drivers/pci/pcie/aspm.c:1186: warning: expecting prototype for pci_enable_link_state(). Prototype was for pci_enable_link_state_locked() instead
> > >
> > >
> > > vim +1186 drivers/pci/pcie/aspm.c
> > >
> > > 1172
> > > 1173 /**
> > > 1174 * pci_enable_link_state - Clear and set the default device link state so that
> >
> > I apparently forgot to update the name here to
> >
> > pci_enable_link_state_locked
> >
>
> While fixing the name, please add locking information in description as well.
It's already there:
Context: Caller holds pci_bus_sem read lock.
Johan
On Fri, Nov 17, 2023 at 11:30:39AM +0100, Johan Hovold wrote:
> On Fri, Nov 17, 2023 at 03:57:24PM +0530, Manivannan Sadhasivam wrote:
> > On Wed, Nov 15, 2023 at 05:06:23PM +0100, Johan Hovold wrote:
> > > On Wed, Nov 15, 2023 at 10:26:40PM +0800, kernel test robot wrote:
> > >
> > > > >> drivers/pci/pcie/aspm.c:1186: warning: expecting prototype for pci_enable_link_state(). Prototype was for pci_enable_link_state_locked() instead
> > > >
> > > >
> > > > vim +1186 drivers/pci/pcie/aspm.c
> > > >
> > > > 1172
> > > > 1173 /**
> > > > 1174 * pci_enable_link_state - Clear and set the default device link state so that
> > >
> > > I apparently forgot to update the name here to
> > >
> > > pci_enable_link_state_locked
> > >
> >
> > While fixing the name, please add locking information in description as well.
>
> It's already there:
>
> Context: Caller holds pci_bus_sem read lock.
Ah, I was looking for it in the description. Fine then!
- Mani
>
> Johan
--
மணிவண்ணன் சதாசிவம்