On Mon, Nov 13, 2023 at 08:00:19AM +0000, Russell King (Oracle) wrote:
> On Mon, Nov 13, 2023 at 10:58:46AM +1000, Gavin Shan wrote:
> >
> >
> > On 11/7/23 20:30, Russell King (Oracle) wrote:
> > > From: James Morse <[email protected]>
> > >
> > > NUMA systems require the node descriptions to be ready before CPUs are
> > > registered. This is so that the node symlinks can be created in sysfs.
> > >
> > > Currently no NUMA platform uses GENERIC_CPU_DEVICES, meaning that CPUs
> > > are registered by arch code, instead of cpu_dev_init().
> > >
> > > Move cpu_dev_init() after node_dev_init() so that NUMA architectures
> > > can use GENERIC_CPU_DEVICES.
> > >
> > > Signed-off-by: James Morse <[email protected]>
> > > Signed-off-by: Russell King (Oracle) <[email protected]>
> > > ---
> > > Note: Jonathan's comment still needs addressing - see
> > > https://lore.kernel.org/r/[email protected]
> > > ---
> > > drivers/base/init.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> >
> > With Jonathan's comments addressed:
>
> That needs James' input, which is why I made the note on the patch.
I'm going to be posting the series without RFC soon, and it will be
with Jonathan's comment unaddressed - because as I've said several
times it needs James' input and we have sadly not yet received that.
Short of waiting until James can respond, I don't think there are
any other alternatives.
I do hope we can get this queued up for v6.8 though.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
On Tue, 21 Nov 2023 13:27:08 +0000
"Russell King (Oracle)" <[email protected]> wrote:
> On Mon, Nov 13, 2023 at 08:00:19AM +0000, Russell King (Oracle) wrote:
> > On Mon, Nov 13, 2023 at 10:58:46AM +1000, Gavin Shan wrote:
> > >
> > >
> > > On 11/7/23 20:30, Russell King (Oracle) wrote:
> > > > From: James Morse <[email protected]>
> > > >
> > > > NUMA systems require the node descriptions to be ready before CPUs are
> > > > registered. This is so that the node symlinks can be created in sysfs.
> > > >
> > > > Currently no NUMA platform uses GENERIC_CPU_DEVICES, meaning that CPUs
> > > > are registered by arch code, instead of cpu_dev_init().
> > > >
> > > > Move cpu_dev_init() after node_dev_init() so that NUMA architectures
> > > > can use GENERIC_CPU_DEVICES.
> > > >
> > > > Signed-off-by: James Morse <[email protected]>
> > > > Signed-off-by: Russell King (Oracle) <[email protected]>
> > > > ---
> > > > Note: Jonathan's comment still needs addressing - see
> > > > https://lore.kernel.org/r/[email protected]
> > > > ---
> > > > drivers/base/init.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > >
> > > With Jonathan's comments addressed:
> >
> > That needs James' input, which is why I made the note on the patch.
>
> I'm going to be posting the series without RFC soon, and it will be
> with Jonathan's comment unaddressed - because as I've said several
> times it needs James' input and we have sadly not yet received that.
>
> Short of waiting until James can respond, I don't think there are
> any other alternatives.
In the interests of expediency I'm fine with that. (To be honest I'd
forgotten I even made that comment ;)
Jonathan
>
> I do hope we can get this queued up for v6.8 though.
>
On Tue, 28 Nov 2023 13:55:36 +0000
Jonathan Cameron <[email protected]> wrote:
> On Tue, 21 Nov 2023 13:27:08 +0000
> "Russell King (Oracle)" <[email protected]> wrote:
>
> > On Mon, Nov 13, 2023 at 08:00:19AM +0000, Russell King (Oracle) wrote:
> > > On Mon, Nov 13, 2023 at 10:58:46AM +1000, Gavin Shan wrote:
> > > >
> > > >
> > > > On 11/7/23 20:30, Russell King (Oracle) wrote:
> > > > > From: James Morse <[email protected]>
> > > > >
> > > > > NUMA systems require the node descriptions to be ready before CPUs are
> > > > > registered. This is so that the node symlinks can be created in sysfs.
> > > > >
> > > > > Currently no NUMA platform uses GENERIC_CPU_DEVICES, meaning that CPUs
> > > > > are registered by arch code, instead of cpu_dev_init().
> > > > >
> > > > > Move cpu_dev_init() after node_dev_init() so that NUMA architectures
> > > > > can use GENERIC_CPU_DEVICES.
> > > > >
> > > > > Signed-off-by: James Morse <[email protected]>
> > > > > Signed-off-by: Russell King (Oracle) <[email protected]>
> > > > > ---
> > > > > Note: Jonathan's comment still needs addressing - see
> > > > > https://lore.kernel.org/r/[email protected]
> > > > > ---
> > > > > drivers/base/init.c | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > >
> > > > With Jonathan's comments addressed:
> > >
> > > That needs James' input, which is why I made the note on the patch.
> >
> > I'm going to be posting the series without RFC soon, and it will be
> > with Jonathan's comment unaddressed - because as I've said several
> > times it needs James' input and we have sadly not yet received that.
> >
> > Short of waiting until James can respond, I don't think there are
> > any other alternatives.
>
> In the interests of expediency I'm fine with that. (To be honest I'd
> forgotten I even made that comment ;)
>
Given what I was looking for was a 'nice to have' extra bit of info in the
patch description and I'm fine with the actual change even without that:
Reviewed-by: Jonathan Cameron <[email protected]>
> Jonathan
>
> >
> > I do hope we can get this queued up for v6.8 though.
*fingers crossed* !
> >
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel