2023-11-17 08:55:02

by Lai Jiangshan

Subject: Re: [RFC PATCH 09/14] KVM: x86: Move shared KVM state into VAC

On Wed, Nov 8, 2023 at 4:21 AM Anish Ghulati <[email protected]> wrote:
>
> From: Venkatesh Srinivas <[email protected]>
>
> Move kcpu_kick_mask and vm_running_vcpu* from arch neutral KVM code into
> VAC.

Hello, Venkatesh, Anish

IMO, the allocation code for cpu_kick_mask has to be moved too.

Thanks

Lai

2023-11-28 18:01:38

by Sean Christopherson

Subject: Re: [RFC PATCH 09/14] KVM: x86: Move shared KVM state into VAC

On Fri, Nov 17, 2023, Lai Jiangshan wrote:
> On Wed, Nov 8, 2023 at 4:21 AM Anish Ghulati <[email protected]> wrote:
> >
> > From: Venkatesh Srinivas <[email protected]>
> >
> > Move kcpu_kick_mask and vm_running_vcpu* from arch neutral KVM code into
> > VAC.
>
> Hello, Venkatesh, Anish
>
> IMO, the allocation code for cpu_kick_mask has to be moved too.

I'm pretty sure this patch should be dropped. I can't think of any reason why
cpu_kick_mask needs to be in VAC, and kvm_running_vcpu definitely needs to be
per-KVM.