2023-11-28 21:48:37

by Rob Herring (Arm)

Subject: [PATCH] dt-bindings: input: sprd,sc27xx-vibrator: Drop incomplete example

The example for the Spreadtrum SC27xx PMIC vibrator is incomplete as the
binding is the full PMIC, not just the sub-functions. It is preferred
for MFD examples to be complete in the top-level MFD device binding
rather than piecemeal in each sub-function binding.

This also fixes an undocumented (by schema) compatible warning for
"sprd,sc2731".

Signed-off-by: Rob Herring <[email protected]>
---
.../bindings/input/sprd,sc27xx-vibrator.yaml | 19 +------------------
1 file changed, 1 insertion(+), 18 deletions(-)

diff --git a/Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml b/Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml
index a401a0bfcbec..4c8d303ff93c 100644
--- a/Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml
+++ b/Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml
@@ -28,21 +28,4 @@ required:

additionalProperties: false

-examples:
- - |
- #include <dt-bindings/interrupt-controller/arm-gic.h>
- sc2731_pmic: pmic@0 {
- compatible = "sprd,sc2731";
- reg = <0 0>;
- spi-max-frequency = <26000000>;
- interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-controller;
- #interrupt-cells = <2>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- vibrator@eb4 {
- compatible = "sprd,sc2731-vibrator";
- reg = <0xeb4>;
- };
- };
+...
--
2.42.0

2023-11-29 08:31:49

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: input: sprd,sc27xx-vibrator: Drop incomplete example

On 28/11/2023 22:48, Rob Herring wrote:
> The example for the Spreadtrum SC27xx PMIC vibrator is incomplete as the
> binding is the full PMIC, not just the sub-functions. It is preferred
> for MFD examples to be complete in the top-level MFD device binding
> rather than piecemeal in each sub-function binding.
>
> This also fixes an undocumented (by schema) compatible warning for
> "sprd,sc2731".
>
> Signed-off-by: Rob Herring <[email protected]>
> ---

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-11-29 21:20:05

by Dmitry Torokhov

Subject: Re: [PATCH] dt-bindings: input: sprd,sc27xx-vibrator: Drop incomplete example

On Tue, Nov 28, 2023 at 03:48:09PM -0600, Rob Herring wrote:
> The example for the Spreadtrum SC27xx PMIC vibrator is incomplete as the
> binding is the full PMIC, not just the sub-functions. It is preferred
> for MFD examples to be complete in the top-level MFD device binding
> rather than piecemeal in each sub-function binding.
>
> This also fixes an undocumented (by schema) compatible warning for
> "sprd,sc2731".
>
> Signed-off-by: Rob Herring <[email protected]>

Applied, thank you.

--
Dmitry