2023-11-28 21:48:44

by Rob Herring (Arm)

Subject: [PATCH] dt-bindings: input: mediatek,pmic-keys: Drop incomplete example

The example for the Mediatek PMIC keys is incomplete as the binding is
the full PMIC, not just the sub-functions. It is preferred for MFD
examples to be complete in the top-level MFD device binding rather than
piecemeal in each sub-function binding.

This also fixes an undocumented (by schema) compatible warning for
"mediatek,mt6397".

Signed-off-by: Rob Herring <[email protected]>
---
.../bindings/input/mediatek,pmic-keys.yaml | 24 +------------------
1 file changed, 1 insertion(+), 23 deletions(-)

diff --git a/Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml b/Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml
index e34c9e78d38d..70567d92c746 100644
--- a/Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml
+++ b/Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml
@@ -90,26 +90,4 @@ required:

unevaluatedProperties: false

-examples:
- - |
- #include <dt-bindings/input/input.h>
- #include <dt-bindings/interrupt-controller/arm-gic.h>
-
- pmic {
- compatible = "mediatek,mt6397";
-
- keys {
- compatible = "mediatek,mt6397-keys";
- mediatek,long-press-mode = <1>;
- power-off-time-sec = <0>;
-
- key-power {
- linux,keycodes = <KEY_POWER>;
- wakeup-source;
- };
-
- key-home {
- linux,keycodes = <KEY_VOLUMEDOWN>;
- };
- };
- };
+...
--
2.42.0

2023-11-29 08:30:26

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: input: mediatek,pmic-keys: Drop incomplete example

On 28/11/2023 22:48, Rob Herring wrote:
> The example for the Mediatek PMIC keys is incomplete as the binding is
> the full PMIC, not just the sub-functions. It is preferred for MFD
> examples to be complete in the top-level MFD device binding rather than
> piecemeal in each sub-function binding.
>
> This also fixes an undocumented (by schema) compatible warning for
> "mediatek,mt6397".
>
> Signed-off-by: Rob Herring <[email protected]>
> ---

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-11-29 21:20:43

by Dmitry Torokhov

Subject: Re: [PATCH] dt-bindings: input: mediatek,pmic-keys: Drop incomplete example

On Tue, Nov 28, 2023 at 03:48:16PM -0600, Rob Herring wrote:
> The example for the Mediatek PMIC keys is incomplete as the binding is
> the full PMIC, not just the sub-functions. It is preferred for MFD
> examples to be complete in the top-level MFD device binding rather than
> piecemeal in each sub-function binding.
>
> This also fixes an undocumented (by schema) compatible warning for
> "mediatek,mt6397".
>
> Signed-off-by: Rob Herring <[email protected]>

Applied, thank you.

--
Dmitry