2023-11-28 15:11:39

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH RFC 14/22] arm64: convert to arch_cpu_is_hotpluggable()

On Tue, 07 Nov 2023 10:30:30 +0000
"Russell King (Oracle)" <[email protected]> wrote:

> Convert arm64 to use the arch_cpu_is_hotpluggable() helper rather than
> arch_register_cpu().
>
> Signed-off-by: Russell King (Oracle) <[email protected]>
Ah. Or previous patch needs a forwards reference to the tweaking
of it it here.

Maybe just smash the 2 together with a Co-developed: ?

I don't care that much so whatever works for you

Reviewed-by: Jonathan Cameron <[email protected]>

> ---
> arch/arm64/kernel/setup.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index 165bd2c0dd5a..42c690bb2d60 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -402,13 +402,9 @@ static inline bool cpu_can_disable(unsigned int cpu)
> return false;
> }
>
> -int arch_register_cpu(int num)
> +bool arch_cpu_is_hotpluggable(int num)
> {
> - struct cpu *cpu = &per_cpu(cpu_devices, num);
> -
> - cpu->hotpluggable = cpu_can_disable(num);
> -
> - return register_cpu(cpu, num);
> + return cpu_can_disable(num);
> }
>
> static void dump_kernel_offset(void)


2023-11-30 12:10:30

by Russell King (Oracle)

[permalink] [raw]
Subject: Re: [PATCH RFC 14/22] arm64: convert to arch_cpu_is_hotpluggable()

On Tue, Nov 28, 2023 at 03:11:15PM +0000, Jonathan Cameron wrote:
> On Tue, 07 Nov 2023 10:30:30 +0000
> "Russell King (Oracle)" <[email protected]> wrote:
>
> > Convert arm64 to use the arch_cpu_is_hotpluggable() helper rather than
> > arch_register_cpu().
> >
> > Signed-off-by: Russell King (Oracle) <[email protected]>
> Ah. Or previous patch needs a forwards reference to the tweaking
> of it it here.
>
> Maybe just smash the 2 together with a Co-developed: ?

I wanted to keep the two separate to preserve the authorship of the
individual patches, so I'll take the former. Thanks.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!