2023-12-11 21:02:27

by Thomas Bogendoerfer

[permalink] [raw]
Subject: Re: [PATCH] MIPS: SGI-IP27: hubio: fix nasid kernel-doc warning

On Fri, Nov 10, 2023 at 07:02:13PM -0800, Randy Dunlap wrote:
> ip27-hubio.c:32: warning: Function parameter or member 'nasid' not described in 'hub_pio_map'
> ip27-hubio.c:32: warning: Excess function parameter 'hub' description in 'hub_pio_map'
>
> Fixes: 4bf841ebf17a ("MIPS: SGI-IP27: get rid of compact node ids")
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Closes: lore.kernel.org/r/[email protected]
> Cc: Thomas Bogendoerfer <[email protected]>
> Cc: Paul Burton <[email protected]>
> Cc: Ralf Baechle <[email protected]>
> Cc: Jiri Slaby <[email protected]>
> Cc: [email protected]
> ---
> arch/mips/sgi-ip27/ip27-hubio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/arch/mips/sgi-ip27/ip27-hubio.c b/arch/mips/sgi-ip27/ip27-hubio.c
> --- a/arch/mips/sgi-ip27/ip27-hubio.c
> +++ b/arch/mips/sgi-ip27/ip27-hubio.c
> @@ -21,7 +21,7 @@ static int force_fire_and_forget = 1;
> /**
> * hub_pio_map - establish a HUB PIO mapping
> *
> - * @hub: hub to perform PIO mapping on
> + * @nasid: nasid to perform PIO mapping on
> * @widget: widget ID to perform PIO mapping for
> * @xtalk_addr: xtalk_address that needs to be mapped
> * @size: size of the PIO mapping

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]