Subject: [PATCH v6 01/40] ARM: ep93xx: Add terminator to gpiod_lookup_table

From: Nikita Shubin <[email protected]>

Without the terminator, if a con_id is passed to gpio_find() that
does not exist in the lookup table the function will not stop looping
correctly, and eventually cause an oops.

Signed-off-by: Nikita Shubin <[email protected]>
---
arch/arm/mach-ep93xx/core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c
index 71b113976420..8b1ec60a9a46 100644
--- a/arch/arm/mach-ep93xx/core.c
+++ b/arch/arm/mach-ep93xx/core.c
@@ -339,6 +339,7 @@ static struct gpiod_lookup_table ep93xx_i2c_gpiod_table = {
GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN),
GPIO_LOOKUP_IDX("G", 0, NULL, 1,
GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN),
+ { }
},
};


--
2.41.0


2023-12-13 17:24:20

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v6 01/40] ARM: ep93xx: Add terminator to gpiod_lookup_table

On Tue, Dec 12, 2023 at 11:20:18AM +0300, Nikita Shubin wrote:
> Without the terminator, if a con_id is passed to gpio_find() that
> does not exist in the lookup table the function will not stop looping
> correctly, and eventually cause an oops.

Reported-by?
Fixes?

--
With Best Regards,
Andy Shevchenko