2023-12-19 03:53:05

by Richard Cochran

Subject: Re: [PATCH net-next v4 1/2] ptp: introduce PTP_CLOCK_EXTOFF event for the measured external offset

On Mon, Dec 18, 2023 at 11:50:44AM -0500, Min Li wrote:
> @@ -50,6 +52,11 @@
> PTP_RISING_EDGE | \
> PTP_FALLING_EDGE)
>
> +/*
> + * flag fields valid for the ptp_extts_event report.
> + */
> +#define PTP_EXTTS_EVENT_VALID_FLAGS (PTP_ENABLE_FEATURE)

Nit: Can we please call this PTP_EXTTS_EVENT_VALID without the _FLAGS suffix?

Thanks,
Richard