Tesla FSD is a derivative of Samsung Exynos SoC, thus just like the
others it reuses several devices from older designs. Historically we
kept the old (block's) compatible only. This works fine and there is no
bug here, however guidelines expressed in
Documentation/devicetree/bindings/writing-bindings.rst state that:
1. Compatibles should be specific.
2. We should add new compatibles in case of bugs or features.
Add Tesla FSD compatible specific to be used with an existing fallback.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
I propose to take the patch through Samsung SoC (me). See cover letter
for explanation.
---
Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml b/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
index c1f5d2cb7709..df9c57bca2a8 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
@@ -29,6 +29,7 @@ properties:
- items:
- enum:
- samsung,exynos5433-hsi2c
+ - tesla,fsd-hsi2c
- const: samsung,exynos7-hsi2c
- items:
- enum:
--
2.34.1
On Tue, 05 Dec 2023 10:22:24 +0100, Krzysztof Kozlowski wrote:
> Tesla FSD is a derivative of Samsung Exynos SoC, thus just like the
> others it reuses several devices from older designs. Historically we
> kept the old (block's) compatible only. This works fine and there is no
> bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
>
> Add Tesla FSD compatible specific to be used with an existing fallback.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> I propose to take the patch through Samsung SoC (me). See cover letter
> for explanation.
> ---
> Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <[email protected]>
On Tue, Dec 05, 2023 at 10:22:24AM +0100, Krzysztof Kozlowski wrote:
> Tesla FSD is a derivative of Samsung Exynos SoC, thus just like the
> others it reuses several devices from older designs. Historically we
> kept the old (block's) compatible only. This works fine and there is no
> bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
>
> Add Tesla FSD compatible specific to be used with an existing fallback.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Wolfram Sang <[email protected]>