2023-12-20 08:19:35

by Sagi Maimon

Subject: [PATCH v1] ptp: ocp: fix bug in unregistering the DPLL subsystem

When unregistering the DPLL subsystem the priv pointer is different then
the one used for registration which cause failure in unregistering.

Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops")
---
drivers/ptp/ptp_ocp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
index 4021d3d325f9..e7defce8cf48 100644
--- a/drivers/ptp/ptp_ocp.c
+++ b/drivers/ptp/ptp_ocp.c
@@ -4492,7 +4492,7 @@ ptp_ocp_remove(struct pci_dev *pdev)
cancel_delayed_work_sync(&bp->sync_work);
for (i = 0; i < OCP_SMA_NUM; i++) {
if (bp->sma[i].dpll_pin) {
- dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin, &dpll_pins_ops, bp);
+ dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin, &dpll_pins_ops, &bp->sma[i]);
dpll_pin_put(bp->sma[i].dpll_pin);
}
}
--
2.26.3

2023-12-20 09:11:07

by Jiri Pirko

Subject: Re: [PATCH v1] ptp: ocp: fix bug in unregistering the DPLL subsystem

Wed, Dec 20, 2023 at 09:19:14AM CET, [email protected] wrote:
>When unregistering the DPLL subsystem the priv pointer is different then
>the one used for registration which cause failure in unregistering.
>
>Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops")

Reviewed-by: Jiri Pirko <[email protected]>

2023-12-29 08:40:35

by patchwork-bot+netdevbpf

Subject: Re: [PATCH v1] ptp: ocp: fix bug in unregistering the DPLL subsystem

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

On Wed, 20 Dec 2023 10:19:14 +0200 you wrote:
> When unregistering the DPLL subsystem the priv pointer is different then
> the one used for registration which cause failure in unregistering.
>
> Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops")
> ---
> drivers/ptp/ptp_ocp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [v1] ptp: ocp: fix bug in unregistering the DPLL subsystem
https://git.kernel.org/netdev/net/c/97417cd79ce1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html