2023-12-19 17:20:25

by Hugo Villeneuve

Subject: [PATCH 14/18] serial: sc16is7xx: drop unneeded MODULE_ALIAS

From: Hugo Villeneuve <[email protected]>

The MODULE_DEVICE_TABLE already creates the proper aliases for the
SPI driver.

Suggested-by: Andy Shevchenko <[email protected]>
Signed-off-by: Hugo Villeneuve <[email protected]>
---
drivers/tty/serial/sc16is7xx.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index 29089b11f6f1..a9e44e5ef713 100644
--- a/drivers/tty/serial/sc16is7xx.c
+++ b/drivers/tty/serial/sc16is7xx.c
@@ -1793,8 +1793,6 @@ static struct spi_driver sc16is7xx_spi_uart_driver = {
.remove = sc16is7xx_spi_remove,
.id_table = sc16is7xx_spi_id_table,
};
-
-MODULE_ALIAS("spi:sc16is7xx");
#endif

#ifdef CONFIG_SERIAL_SC16IS7XX_I2C
--
2.39.2

2023-12-20 15:55:38

by Andy Shevchenko

Subject: Re: [PATCH 14/18] serial: sc16is7xx: drop unneeded MODULE_ALIAS

On Tue, Dec 19, 2023 at 12:18:58PM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <[email protected]>
>
> The MODULE_DEVICE_TABLE already creates the proper aliases for the

MODULE_DEVICE_TABLE()

> SPI driver.

With the above fixed
Reviewed-by: Andy Shevchenko <[email protected]>

--
With Best Regards,
Andy Shevchenko

2023-12-20 16:28:00

by Hugo Villeneuve

Subject: Re: [PATCH 14/18] serial: sc16is7xx: drop unneeded MODULE_ALIAS

On Wed, 20 Dec 2023 17:54:55 +0200
Andy Shevchenko <[email protected]> wrote:

> On Tue, Dec 19, 2023 at 12:18:58PM -0500, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <[email protected]>
> >
> > The MODULE_DEVICE_TABLE already creates the proper aliases for the
>
> MODULE_DEVICE_TABLE()

Done for V2.

Hugo.


>
> > SPI driver.
>
> With the above fixed
> Reviewed-by: Andy Shevchenko <[email protected]>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
>


--
Hugo Villeneuve