2023-12-20 00:51:59

by Yang Li

[permalink] [raw]
Subject: [PATCH -next] tools/counter: Remove unneeded semicolon

./tools/counter/counter_watch_events.c:233:3-4: Unneeded semicolon
./tools/counter/counter_watch_events.c:234:2-3: Unneeded semicolon
./tools/counter/counter_watch_events.c:333:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7782
Signed-off-by: Yang Li <[email protected]>
---
tools/counter/counter_watch_events.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/counter/counter_watch_events.c b/tools/counter/counter_watch_events.c
index 3898fe7e35ec..2ce4c99ebd01 100644
--- a/tools/counter/counter_watch_events.c
+++ b/tools/counter/counter_watch_events.c
@@ -230,8 +230,8 @@ int main(int argc, char **argv)
break;
default:
return EXIT_FAILURE;
- };
- };
+ }
+ }

if (nwatch) {
watches = calloc(nwatch, sizeof(*watches));
@@ -330,7 +330,7 @@ int main(int argc, char **argv)
i++;
break;
}
- };
+ }

if (debug)
print_watch(watches, nwatch);
--
2.20.1.7.g153144c



2023-12-20 15:54:46

by Fabrice Gasnier

[permalink] [raw]
Subject: Re: [PATCH -next] tools/counter: Remove unneeded semicolon

On 12/20/23 01:51, Yang Li wrote:
> ./tools/counter/counter_watch_events.c:233:3-4: Unneeded semicolon
> ./tools/counter/counter_watch_events.c:234:2-3: Unneeded semicolon
> ./tools/counter/counter_watch_events.c:333:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7782
> Signed-off-by: Yang Li <[email protected]>

Hi Yang,

Reviewed-by: Fabrice Gasnier <[email protected]>

Thanks for your patch,
Best Regards,
Fabrice

> ---
> tools/counter/counter_watch_events.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/counter/counter_watch_events.c b/tools/counter/counter_watch_events.c
> index 3898fe7e35ec..2ce4c99ebd01 100644
> --- a/tools/counter/counter_watch_events.c
> +++ b/tools/counter/counter_watch_events.c
> @@ -230,8 +230,8 @@ int main(int argc, char **argv)
> break;
> default:
> return EXIT_FAILURE;
> - };
> - };
> + }
> + }
>
> if (nwatch) {
> watches = calloc(nwatch, sizeof(*watches));
> @@ -330,7 +330,7 @@ int main(int argc, char **argv)
> i++;
> break;
> }
> - };
> + }
>
> if (debug)
> print_watch(watches, nwatch);

2023-12-20 16:44:57

by William Breathitt Gray

[permalink] [raw]
Subject: Re: [PATCH -next] tools/counter: Remove unneeded semicolon

On Wed, 20 Dec 2023 08:51:43 +0800, Yang Li wrote:
> ./tools/counter/counter_watch_events.c:233:3-4: Unneeded semicolon
> ./tools/counter/counter_watch_events.c:234:2-3: Unneeded semicolon
> ./tools/counter/counter_watch_events.c:333:2-3: Unneeded semicolon
>
>

Applied, thanks!

[1/1] tools/counter: Remove unneeded semicolon
commit: b7760cf94d4f2665bf40d08dd69aa5d0b4aa593f

William Breathitt Gray

Attachments:
(No filename) (422.00 B)
 signature.asc (235.00 B)
 Download all attachments