2023-12-19 14:35:39

by Michal Simek

Subject: [PATCH] dt-bindings: firmware: xilinx: Fix versal-fpga node name

Based on commit 83a368a3fc8a ("docs: dt-bindings: add DTS Coding Style
document") using underscore ('_') in node name is not recommended that's
why switch to dash ('-').

Signed-off-by: Michal Simek <[email protected]>
---

.../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml | 4 ++--
Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
index 8e584857ddd4..3d578f98ae2c 100644
--- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
+++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
@@ -41,7 +41,7 @@ properties:
"#power-domain-cells":
const: 1

- versal_fpga:
+ versal-fpga:
$ref: /schemas/fpga/xlnx,versal-fpga.yaml#
description: Compatible of the FPGA device.
type: object
@@ -84,7 +84,7 @@ examples:
compatible = "xlnx,versal-firmware";
method = "smc";

- versal_fpga: versal_fpga {
+ versal_fpga: versal-fpga {
compatible = "xlnx,versal-fpga";
};

diff --git a/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
index 26f18834caa3..80833462f620 100644
--- a/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
+++ b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
@@ -26,7 +26,7 @@ additionalProperties: false

examples:
- |
- versal_fpga: versal_fpga {
+ versal_fpga: versal-fpga {
compatible = "xlnx,versal-fpga";
};

--
2.36.1

2023-12-20 07:54:49

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: firmware: xilinx: Fix versal-fpga node name

On 19/12/2023 15:31, Michal Simek wrote:
> Based on commit 83a368a3fc8a ("docs: dt-bindings: add DTS Coding Style
> document") using underscore ('_') in node name is not recommended that's
> why switch to dash ('-').
>
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
> .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml | 4 ++--
> Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> index 8e584857ddd4..3d578f98ae2c 100644
> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> @@ -41,7 +41,7 @@ properties:
> "#power-domain-cells":
> const: 1
>

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-12-21 14:01:47

by Xu Yilun

Subject: Re: [PATCH] dt-bindings: firmware: xilinx: Fix versal-fpga node name

On Wed, Dec 20, 2023 at 08:54:33AM +0100, Krzysztof Kozlowski wrote:
> On 19/12/2023 15:31, Michal Simek wrote:
> > Based on commit 83a368a3fc8a ("docs: dt-bindings: add DTS Coding Style
> > document") using underscore ('_') in node name is not recommended that's
> > why switch to dash ('-').
> >
> > Signed-off-by: Michal Simek <[email protected]>
> > ---
> >
> > .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml | 4 ++--
> > Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> > index 8e584857ddd4..3d578f98ae2c 100644
> > --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> > +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> > @@ -41,7 +41,7 @@ properties:
> > "#power-domain-cells":
> > const: 1
> >
>
> Acked-by: Krzysztof Kozlowski <[email protected]>

Acked-by: Xu Yilun <[email protected]>

>
> Best regards,
> Krzysztof
>
>

2024-01-22 13:03:15

by Michal Simek

Subject: Re: [PATCH] dt-bindings: firmware: xilinx: Fix versal-fpga node name

On 12/19/23 15:31, Michal Simek wrote:
> Based on commit 83a368a3fc8a ("docs: dt-bindings: add DTS Coding Style
> document") using underscore ('_') in node name is not recommended that's
> why switch to dash ('-').
>
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
> .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml | 4 ++--
> Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> index 8e584857ddd4..3d578f98ae2c 100644
> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> @@ -41,7 +41,7 @@ properties:
> "#power-domain-cells":
> const: 1
>
> - versal_fpga:
> + versal-fpga:
> $ref: /schemas/fpga/xlnx,versal-fpga.yaml#
> description: Compatible of the FPGA device.
> type: object
> @@ -84,7 +84,7 @@ examples:
> compatible = "xlnx,versal-firmware";
> method = "smc";
>
> - versal_fpga: versal_fpga {
> + versal_fpga: versal-fpga {
> compatible = "xlnx,versal-fpga";
> };
>
> diff --git a/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
> index 26f18834caa3..80833462f620 100644
> --- a/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
> +++ b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
> @@ -26,7 +26,7 @@ additionalProperties: false
>
> examples:
> - |
> - versal_fpga: versal_fpga {
> + versal_fpga: versal-fpga {
> compatible = "xlnx,versal-fpga";
> };
>

Applied.
M