2023-12-21 21:48:02

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the mux tree

Hi all,

In commit

2e142cebb164 ("dmaengine: xilinx: xdma: Rework xdma_terminate_all()")

Fixes tag

Fixes: 49a701d8dc1e ("dmaengine: xilinx: xdma: Add terminate_all/synchronize callbacks")

has these problem(s):

- Target SHA1 does not exist

Maybe you meant

Fixes: 5c392d106e7 ("dmaengine: xilinx: xdma: Add terminate_all/synchronize callbacks")

Also, please keep all the commit message tags together at the end of
the commit message.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2023-12-21 21:49:22

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the mux tree

Hi all,

On Fri, 22 Dec 2023 08:47:46 +1100 Stephen Rothwell <[email protected]> wrote:
>
> In commit
>
> 2e142cebb164 ("dmaengine: xilinx: xdma: Rework xdma_terminate_all()")
>
> Fixes tag
>
> Fixes: 49a701d8dc1e ("dmaengine: xilinx: xdma: Add terminate_all/synchronize callbacks")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 5c392d106e7 ("dmaengine: xilinx: xdma: Add terminate_all/synchronize callbacks")
>
> Also, please keep all the commit message tags together at the end of
> the commit message.

Sorry, that is in the dmaengine tree, not the mux tree.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2023-12-22 06:54:32

by Vinod Koul

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the mux tree

On 22-12-23, 08:47, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 2e142cebb164 ("dmaengine: xilinx: xdma: Rework xdma_terminate_all()")
>
> Fixes tag
>
> Fixes: 49a701d8dc1e ("dmaengine: xilinx: xdma: Add terminate_all/synchronize callbacks")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 5c392d106e7 ("dmaengine: xilinx: xdma: Add terminate_all/synchronize callbacks")

It should be Fixes: f5c392d106e7 ("dmaengine: xilinx: xdma: Add terminate_all/synchronize callbacks")

I have fixed that

> Also, please keep all the commit message tags together at the end of
> the commit message.

Yes this one too and pushed out

--
~Vinod