2023-12-23 13:54:16

by Thomas Weißschuh

[permalink] [raw]
Subject: [PATCH] sysctl: delete unused define SYSCTL_PERM_EMPTY_DIR

It seems it was never used.

Fixes: 2f2665c13af4 ("sysctl: replace child with an enumeration")
Signed-off-by: Thomas Weißschuh <[email protected]>
---
This was originally part of the sysctl-const series [0], but it doesn't
really belong in there.
To slim down that series as much as possible, submit this patch on its
own.

[0] https://lore.kernel.org/lkml/[email protected]/
---
include/linux/sysctl.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h
index 61b40ea81f4d..26a38161c28f 100644
--- a/include/linux/sysctl.h
+++ b/include/linux/sysctl.h
@@ -255,8 +255,6 @@ extern int unaligned_enabled;
extern int unaligned_dump_stack;
extern int no_unaligned_warning;

-#define SYSCTL_PERM_EMPTY_DIR (1 << 0)
-
#else /* CONFIG_SYSCTL */

static inline void register_sysctl_init(const char *path, struct ctl_table *table)

---
base-commit: a6fd07f80ab7bd94edb4d56c35e61117ffb9957e
change-id: 20231223-sysctl-perm-empty-dir-7a71b4e3867b

Best regards,
--
Thomas Weißschuh <[email protected]>



2023-12-23 18:26:03

by Luis Chamberlain

[permalink] [raw]
Subject: Re: [PATCH] sysctl: delete unused define SYSCTL_PERM_EMPTY_DIR

On Sat, Dec 23, 2023 at 02:53:47PM +0100, Thomas Weißschuh wrote:
> It seems it was never used.
>
> Fixes: 2f2665c13af4 ("sysctl: replace child with an enumeration")
> Signed-off-by: Thomas Weißschuh <[email protected]>
> ---
> This was originally part of the sysctl-const series [0], but it doesn't
> really belong in there.
> To slim down that series as much as possible, submit this patch on its
> own.
>
> [0] https://lore.kernel.org/lkml/[email protected]/

Applied, and pushed! BTW:

$ b4 am -s
[email protected]
Grabbing thread from
lore.kernel.org/all/[email protected]/t.mbox.gz
Analyzing 1 messages in the thread
Checking attestation on all messages, may take a moment...
---
✓ [PATCH] sysctl: delete unused define SYSCTL_PERM_EMPTY_DIR
+ Signed-off-by: Luis Chamberlain <[email protected]>
---
✗ No key: ed25519/[email protected]
✓ Signed: DKIM/weissschuh.net

Luis


2023-12-24 10:42:57

by Thomas Weißschuh

[permalink] [raw]
Subject: Re: [PATCH] sysctl: delete unused define SYSCTL_PERM_EMPTY_DIR

On 2023-12-23 10:25:41-0800, Luis Chamberlain wrote:
> On Sat, Dec 23, 2023 at 02:53:47PM +0100, Thomas Weißschuh wrote:
> > It seems it was never used.
> >
> > Fixes: 2f2665c13af4 ("sysctl: replace child with an enumeration")
> > Signed-off-by: Thomas Weißschuh <[email protected]>
> > ---
> > This was originally part of the sysctl-const series [0], but it doesn't
> > really belong in there.
> > To slim down that series as much as possible, submit this patch on its
> > own.
> >
> > [0] https://lore.kernel.org/lkml/[email protected]/
>
> Applied, and pushed! BTW:

Thanks!

> $ b4 am -s [email protected]
> Grabbing thread from
> lore.kernel.org/all/[email protected]/t.mbox.gz
> Analyzing 1 messages in the thread
> Checking attestation on all messages, may take a moment...
> ---
> ✓ [PATCH] sysctl: delete unused define SYSCTL_PERM_EMPTY_DIR
> + Signed-off-by: Luis Chamberlain <[email protected]>
> ---
> ✗ No key: ed25519/[email protected]
> ✓ Signed: DKIM/weissschuh.net

b4 needs a manual import of contributor keys for it to validate them:

https://b4.docs.kernel.org/en/latest/maintainer/kr.html


Thomas