2024-01-04 19:31:47

by Tanzir Hasan

Subject: [PATCH] android: removed duplicate linux/errno

There are two linux/errno.h inclusions in this file. The second one has
been removed and the file builds correctly.

Fixes: 54ffdab82080 ("android: binder: binderfs.c: removed asm-generic/errno-base.h")
Reviewed-by: Nick Desaulniers <[email protected]>
Tested-by: Nick Desaulniers <[email protected]>
Signed-off-by: Tanzir Hasan <[email protected]>
---

---
drivers/android/binderfs.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
index d04ff6029480..3001d754ac36 100644
--- a/drivers/android/binderfs.c
+++ b/drivers/android/binderfs.c
@@ -29,7 +29,6 @@
#include <linux/uaccess.h>
#include <linux/user_namespace.h>
#include <linux/xarray.h>
-#include <linux/errno.h>
#include <uapi/linux/android/binder.h>
#include <uapi/linux/android/binderfs.h>


---
base-commit: 0c9ae0b8605078eafc3bea053cc78791e97ba2e2
change-id: 20240104-removeduperror-9b6954a0c52c

Best regards,
--
Tanzir Hasan <[email protected]>

2024-01-06 16:35:49

by Carlos Llamas

Subject: Re: [PATCH] android: removed duplicate linux/errno

On Thu, Jan 04, 2024 at 07:31:36PM +0000, Tanzir Hasan wrote:
> There are two linux/errno.h inclusions in this file. The second one has
> been removed and the file builds correctly.
>
> Fixes: 54ffdab82080 ("android: binder: binderfs.c: removed asm-generic/errno-base.h")

I'm not sure that we can I this tag before the patch hits mainline. I
suppose it's ok since char-misc doesn't do forced updates?

Greg, is this fine?

If it is, then:
Acked-by: Carlos Llamas <[email protected]>

Thanks,
--
Carlos Llamas

2024-01-07 08:48:23

by Greg Kroah-Hartman

Subject: Re: [PATCH] android: removed duplicate linux/errno

On Sat, Jan 06, 2024 at 04:35:30PM +0000, Carlos Llamas wrote:
> On Thu, Jan 04, 2024 at 07:31:36PM +0000, Tanzir Hasan wrote:
> > There are two linux/errno.h inclusions in this file. The second one has
> > been removed and the file builds correctly.
> >
> > Fixes: 54ffdab82080 ("android: binder: binderfs.c: removed asm-generic/errno-base.h")
>
> I'm not sure that we can I this tag before the patch hits mainline. I
> suppose it's ok since char-misc doesn't do forced updates?

Yes, char-misc does not rebase (like any sane public-facing branch.)

> Greg, is this fine?

Yes.

thanks,

greg k-h