2024-01-08 12:18:24

by Lukas Bulwahn

Subject: [PATCH] drm: Clean-up superfluously selecting VT_HW_CONSOLE_BINDING

As config FRAMEBUFFER_CONSOLE already selects VT_HW_CONSOLE_BINDING, there
is no need for any drm driver to repeat that rule for selecting.

Remove those duplications of selecting VT_HW_CONSOLE_BINDING.

Signed-off-by: Lukas Bulwahn <[email protected]>
---
drivers/gpu/drm/ingenic/Kconfig | 1 -
drivers/gpu/drm/mcde/Kconfig | 1 -
drivers/gpu/drm/pl111/Kconfig | 1 -
drivers/gpu/drm/tve200/Kconfig | 1 -
4 files changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig
index b440e0cdc057..3db117c5edd9 100644
--- a/drivers/gpu/drm/ingenic/Kconfig
+++ b/drivers/gpu/drm/ingenic/Kconfig
@@ -11,7 +11,6 @@ config DRM_INGENIC
select DRM_GEM_DMA_HELPER
select REGMAP
select REGMAP_MMIO
- select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
help
Choose this option for DRM support for the Ingenic SoCs.

diff --git a/drivers/gpu/drm/mcde/Kconfig b/drivers/gpu/drm/mcde/Kconfig
index 4f3d68e11bc1..907460b69d4f 100644
--- a/drivers/gpu/drm/mcde/Kconfig
+++ b/drivers/gpu/drm/mcde/Kconfig
@@ -11,7 +11,6 @@ config DRM_MCDE
select DRM_PANEL_BRIDGE
select DRM_KMS_HELPER
select DRM_GEM_DMA_HELPER
- select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
help
Choose this option for DRM support for the ST-Ericsson MCDE
Multi-Channel Display Engine.
diff --git a/drivers/gpu/drm/pl111/Kconfig b/drivers/gpu/drm/pl111/Kconfig
index ad24cdf1d992..20fe1d2c0aaf 100644
--- a/drivers/gpu/drm/pl111/Kconfig
+++ b/drivers/gpu/drm/pl111/Kconfig
@@ -9,7 +9,6 @@ config DRM_PL111
select DRM_GEM_DMA_HELPER
select DRM_BRIDGE
select DRM_PANEL_BRIDGE
- select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
help
Choose this option for DRM support for the PL111 CLCD controller.
If M is selected the module will be called pl111_drm.
diff --git a/drivers/gpu/drm/tve200/Kconfig b/drivers/gpu/drm/tve200/Kconfig
index 11e865be81c6..5121fed571a5 100644
--- a/drivers/gpu/drm/tve200/Kconfig
+++ b/drivers/gpu/drm/tve200/Kconfig
@@ -9,7 +9,6 @@ config DRM_TVE200
select DRM_PANEL_BRIDGE
select DRM_KMS_HELPER
select DRM_GEM_DMA_HELPER
- select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
help
Choose this option for DRM support for the Faraday TV Encoder
TVE200 Controller.
--
2.17.1

2024-01-08 12:49:53

by Daniel Vetter

Subject: Re: [PATCH] drm: Clean-up superfluously selecting VT_HW_CONSOLE_BINDING

On Mon, Jan 08, 2024 at 01:17:57PM +0100, Lukas Bulwahn wrote:
> As config FRAMEBUFFER_CONSOLE already selects VT_HW_CONSOLE_BINDING, there
> is no need for any drm driver to repeat that rule for selecting.
>
> Remove those duplications of selecting VT_HW_CONSOLE_BINDING.

This is only tree since a5ae331edb02 ("drm: Drop select
FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION") because select isn't
recursive and therefore dependencies had to be replicated. Which means
your patch without the above would result in build failures with
randomized configs.

I've added that clarification to your patch and merged it to
drm-misc-next, thanks.

Cheers, Sima

> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> drivers/gpu/drm/ingenic/Kconfig | 1 -
> drivers/gpu/drm/mcde/Kconfig | 1 -
> drivers/gpu/drm/pl111/Kconfig | 1 -
> drivers/gpu/drm/tve200/Kconfig | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig
> index b440e0cdc057..3db117c5edd9 100644
> --- a/drivers/gpu/drm/ingenic/Kconfig
> +++ b/drivers/gpu/drm/ingenic/Kconfig
> @@ -11,7 +11,6 @@ config DRM_INGENIC
> select DRM_GEM_DMA_HELPER
> select REGMAP
> select REGMAP_MMIO
> - select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
> help
> Choose this option for DRM support for the Ingenic SoCs.
>
> diff --git a/drivers/gpu/drm/mcde/Kconfig b/drivers/gpu/drm/mcde/Kconfig
> index 4f3d68e11bc1..907460b69d4f 100644
> --- a/drivers/gpu/drm/mcde/Kconfig
> +++ b/drivers/gpu/drm/mcde/Kconfig
> @@ -11,7 +11,6 @@ config DRM_MCDE
> select DRM_PANEL_BRIDGE
> select DRM_KMS_HELPER
> select DRM_GEM_DMA_HELPER
> - select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
> help
> Choose this option for DRM support for the ST-Ericsson MCDE
> Multi-Channel Display Engine.
> diff --git a/drivers/gpu/drm/pl111/Kconfig b/drivers/gpu/drm/pl111/Kconfig
> index ad24cdf1d992..20fe1d2c0aaf 100644
> --- a/drivers/gpu/drm/pl111/Kconfig
> +++ b/drivers/gpu/drm/pl111/Kconfig
> @@ -9,7 +9,6 @@ config DRM_PL111
> select DRM_GEM_DMA_HELPER
> select DRM_BRIDGE
> select DRM_PANEL_BRIDGE
> - select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
> help
> Choose this option for DRM support for the PL111 CLCD controller.
> If M is selected the module will be called pl111_drm.
> diff --git a/drivers/gpu/drm/tve200/Kconfig b/drivers/gpu/drm/tve200/Kconfig
> index 11e865be81c6..5121fed571a5 100644
> --- a/drivers/gpu/drm/tve200/Kconfig
> +++ b/drivers/gpu/drm/tve200/Kconfig
> @@ -9,7 +9,6 @@ config DRM_TVE200
> select DRM_PANEL_BRIDGE
> select DRM_KMS_HELPER
> select DRM_GEM_DMA_HELPER
> - select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
> help
> Choose this option for DRM support for the Faraday TV Encoder
> TVE200 Controller.
> --
> 2.17.1
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch