2024-01-19 13:36:53

by Thomas Bogendoerfer

Subject: [PATCH] MIPS: fw arc: Fix missing prototypes

Make ArcGetMemoryDescriptor() static since it's only needed internally.

Signed-off-by: Thomas Bogendoerfer <[email protected]>
---
arch/mips/fw/arc/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/fw/arc/memory.c b/arch/mips/fw/arc/memory.c
index 66188739f54d..fb78e6fd5de4 100644
--- a/arch/mips/fw/arc/memory.c
+++ b/arch/mips/fw/arc/memory.c
@@ -37,7 +37,7 @@ static unsigned int nr_prom_mem __initdata;
*/
#define ARC_PAGE_SHIFT 12

-struct linux_mdesc * __init ArcGetMemoryDescriptor(struct linux_mdesc *Current)
+static struct linux_mdesc * __init ArcGetMemoryDescriptor(struct linux_mdesc *Current)
{
return (struct linux_mdesc *) ARC_CALL1(get_mdesc, Current);
}
--
2.35.3

2024-01-19 17:55:00

by Florian Fainelli

Subject: Re: [PATCH] MIPS: fw arc: Fix missing prototypes

On 1/19/24 05:36, Thomas Bogendoerfer wrote:
> Make ArcGetMemoryDescriptor() static since it's only needed internally.
>
> Signed-off-by: Thomas Bogendoerfer <[email protected]>

Reviewed-by: Florian Fainelli <[email protected]>
--
Florian

2024-01-22 10:16:39

by Thomas Bogendoerfer

Subject: Re: [PATCH] MIPS: fw arc: Fix missing prototypes

On Fri, Jan 19, 2024 at 02:36:34PM +0100, Thomas Bogendoerfer wrote:
> Make ArcGetMemoryDescriptor() static since it's only needed internally.
>
> Signed-off-by: Thomas Bogendoerfer <[email protected]>
> ---
> arch/mips/fw/arc/memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/fw/arc/memory.c b/arch/mips/fw/arc/memory.c
> index 66188739f54d..fb78e6fd5de4 100644
> --- a/arch/mips/fw/arc/memory.c
> +++ b/arch/mips/fw/arc/memory.c
> @@ -37,7 +37,7 @@ static unsigned int nr_prom_mem __initdata;
> */
> #define ARC_PAGE_SHIFT 12
>
> -struct linux_mdesc * __init ArcGetMemoryDescriptor(struct linux_mdesc *Current)
> +static struct linux_mdesc * __init ArcGetMemoryDescriptor(struct linux_mdesc *Current)
> {
> return (struct linux_mdesc *) ARC_CALL1(get_mdesc, Current);
> }
> --
> 2.35.3

applied to mips-fixes

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]