2024-01-12 05:17:41

by Randy Dunlap

Subject: [PATCH] drm/doc: internals: remove section on PCI legacy support

The functions that were described in this section of
drm-internals.rst were removed in NOV-2023, along with all of the
kernel-doc comments in the source file. This now causes a
docs build warning, so remove that section of the documentation also.

drivers/gpu/drm/drm_pci.c:1: warning: no structured comments found

Fixes: 2504c7ec728b ("drm: Remove source code for non-KMS drivers")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Thomas Zimmermann <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: [email protected]
Cc: Jonathan Corbet <[email protected]>
Cc: [email protected]
---
Documentation/gpu/drm-internals.rst | 12 ------------
1 file changed, 12 deletions(-)

diff -- a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/drm-internals.rst
--- a/Documentation/gpu/drm-internals.rst
+++ b/Documentation/gpu/drm-internals.rst
@@ -153,18 +153,6 @@ Managed Resources
.. kernel-doc:: include/drm/drm_managed.h
:internal:

-Bus-specific Device Registration and PCI Support
-------------------------------------------------
-
-A number of functions are provided to help with device registration. The
-functions deal with PCI and platform devices respectively and are only
-provided for historical reasons. These are all deprecated and shouldn't
-be used in new drivers. Besides that there's a few helpers for pci
-drivers.
-
-.. kernel-doc:: drivers/gpu/drm/drm_pci.c
- :export:
-
Open/Close, File Operations and IOCTLs
======================================

2024-01-12 12:59:11

by Daniel Vetter

Subject: Re: [PATCH] drm/doc: internals: remove section on PCI legacy support

On Thu, Jan 11, 2024 at 09:17:31PM -0800, Randy Dunlap wrote:
> The functions that were described in this section of
> drm-internals.rst were removed in NOV-2023, along with all of the
> kernel-doc comments in the source file. This now causes a
> docs build warning, so remove that section of the documentation also.
>
> drivers/gpu/drm/drm_pci.c:1: warning: no structured comments found
>
> Fixes: 2504c7ec728b ("drm: Remove source code for non-KMS drivers")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Thomas Zimmermann <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: [email protected]
> Cc: Jonathan Corbet <[email protected]>
> Cc: [email protected]

Applied to drm-misc-next, thanks!
-Sima

> ---
> Documentation/gpu/drm-internals.rst | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff -- a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/drm-internals.rst
> --- a/Documentation/gpu/drm-internals.rst
> +++ b/Documentation/gpu/drm-internals.rst
> @@ -153,18 +153,6 @@ Managed Resources
> .. kernel-doc:: include/drm/drm_managed.h
> :internal:
>
> -Bus-specific Device Registration and PCI Support
> -------------------------------------------------
> -
> -A number of functions are provided to help with device registration. The
> -functions deal with PCI and platform devices respectively and are only
> -provided for historical reasons. These are all deprecated and shouldn't
> -be used in new drivers. Besides that there's a few helpers for pci
> -drivers.
> -
> -.. kernel-doc:: drivers/gpu/drm/drm_pci.c
> - :export:
> -
> Open/Close, File Operations and IOCTLs
> ======================================
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch