2024-01-24 18:38:27

by Kousik Sanagavarapu

[permalink] [raw]
Subject: [PATCH] gpu: drm: display: indent fix in comment

The comments explaining the function "drm_dp_mst_atom_check_mgr()" had
uneven indentation which made "make htmldocs" complain:

Documentation/gpu/drm-kms-helpers:296:
./drivers/gpu/drm/display/drm_dp_mst_topology.c:5496:
ERROR: Unexpected indentation.

Documentation/gpu/drm-kms-helpers:296:
./drivers/gpu/drm/display/drm_dp_mst_topology.c:5500:
WARNING: Block quote ends without a blank line; unexpected unindent.

Fix this by getting the indent right.

Signed-off-by: Kousik Sanagavarapu <[email protected]>
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
index bd6c24d4213c..f26cc85e7dbf 100644
--- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
@@ -5490,15 +5490,15 @@ EXPORT_SYMBOL(drm_dp_mst_atomic_enable_dsc);
* Returns:
* - 0 if the new state is valid
* - %-ENOSPC, if the new state is invalid, because of BW limitation
- * @failing_port is set to:
- * - The non-root port where a BW limit check failed
- * with all the ports downstream of @failing_port passing
- * the BW limit check.
- * The returned port pointer is valid until at least
- * one payload downstream of it exists.
- * - %NULL if the BW limit check failed at the root port
- * with all the ports downstream of the root port passing
- * the BW limit check.
+ * @failing_port is set to:
+ *
+ * - The non-root port where a BW limit check failed with all the ports
+ * downstream of @failing_port passing the BW limit check.
+ * The returned port pointer is valid until at least one payload
+ * downstream of it exists.
+ * - %NULL if the BW limit check failed at the root port with all the
+ * ports downstream of the root port passing the BW limit check.
+ *
* - %-EINVAL, if the new state is invalid, because the root port has
* too many payloads.
*/
--
2.43.0.370.g8962b674a6.dirty



2024-02-02 16:07:06

by Kousik Sanagavarapu

[permalink] [raw]
Subject: Re: [PATCH] gpu: drm: display: indent fix in comment

On Thu, Jan 25, 2024 at 12:05:56AM +0530, Kousik Sanagavarapu wrote:
> The comments explaining the function "drm_dp_mst_atom_check_mgr()" had
> uneven indentation which made "make htmldocs" complain:
>
> Documentation/gpu/drm-kms-helpers:296:
> ./drivers/gpu/drm/display/drm_dp_mst_topology.c:5496:
> ERROR: Unexpected indentation.
>
> Documentation/gpu/drm-kms-helpers:296:
> ./drivers/gpu/drm/display/drm_dp_mst_topology.c:5500:
> WARNING: Block quote ends without a blank line; unexpected unindent.
>
> Fix this by getting the indent right.
>
> Signed-off-by: Kousik Sanagavarapu <[email protected]>

Ping.

Thanks

2024-02-08 15:21:08

by Kousik Sanagavarapu

[permalink] [raw]
Subject: Re: [PATCH] gpu: drm: display: indent fix in comment

On Thu, Jan 25, 2024 at 12:05:56AM +0530, Kousik Sanagavarapu wrote:
> The comments explaining the function "drm_dp_mst_atom_check_mgr()" had
> uneven indentation which made "make htmldocs" complain:
>
> Documentation/gpu/drm-kms-helpers:296:
> ./drivers/gpu/drm/display/drm_dp_mst_topology.c:5496:
> ERROR: Unexpected indentation.
>
> Documentation/gpu/drm-kms-helpers:296:
> ./drivers/gpu/drm/display/drm_dp_mst_topology.c:5500:
> WARNING: Block quote ends without a blank line; unexpected unindent.
>
> Fix this by getting the indent right.
>
> Signed-off-by: Kousik Sanagavarapu <[email protected]>
> --

Ping again.

Thanks

2024-02-11 06:50:04

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] gpu: drm: display: indent fix in comment



On 2/8/24 07:20, Kousik Sanagavarapu wrote:
> On Thu, Jan 25, 2024 at 12:05:56AM +0530, Kousik Sanagavarapu wrote:
>> The comments explaining the function "drm_dp_mst_atom_check_mgr()" had
>> uneven indentation which made "make htmldocs" complain:
>>
>> Documentation/gpu/drm-kms-helpers:296:
>> ./drivers/gpu/drm/display/drm_dp_mst_topology.c:5496:
>> ERROR: Unexpected indentation.
>>
>> Documentation/gpu/drm-kms-helpers:296:
>> ./drivers/gpu/drm/display/drm_dp_mst_topology.c:5500:
>> WARNING: Block quote ends without a blank line; unexpected unindent.
>>
>> Fix this by getting the indent right.
>>
>> Signed-off-by: Kousik Sanagavarapu <[email protected]>
>> --
>
> Ping again.
>
> Thanks

Hi,
This seems to be fixed by commit 1a84c213146a.

If you don't agree, please explain.
Thanks.

--
#Randy

2024-02-12 14:17:31

by Kousik Sanagavarapu

[permalink] [raw]
Subject: Re: [PATCH] gpu: drm: display: indent fix in comment

On Sat, Feb 10, 2024 at 10:49:50PM -0800, Randy Dunlap wrote:
>
>
> On 2/8/24 07:20, Kousik Sanagavarapu wrote:
> > On Thu, Jan 25, 2024 at 12:05:56AM +0530, Kousik Sanagavarapu wrote:
> >> The comments explaining the function "drm_dp_mst_atom_check_mgr()" had
> >> uneven indentation which made "make htmldocs" complain:
> >>
> >> Documentation/gpu/drm-kms-helpers:296:
> >> ./drivers/gpu/drm/display/drm_dp_mst_topology.c:5496:
> >> ERROR: Unexpected indentation.
> >>
> >> Documentation/gpu/drm-kms-helpers:296:
> >> ./drivers/gpu/drm/display/drm_dp_mst_topology.c:5500:
> >> WARNING: Block quote ends without a blank line; unexpected unindent.
> >>
> >> Fix this by getting the indent right.
> >>
> >> Signed-off-by: Kousik Sanagavarapu <[email protected]>
> >> --
> >
> > Ping again.
> >
> > Thanks
>
> Hi,
> This seems to be fixed by commit 1a84c213146a.

Makes sense. Sorry for the noise.

> If you don't agree, please explain.
> Thanks.
>
> --
> #Randy