The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not
relevant and shouldn't be referenced.
Signed-off-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml b/Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml
index 2c08f2a7cf1e..dd3d24212551 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml
@@ -32,7 +32,6 @@ description: |
+-------------------------------+
allOf:
- - $ref: i2c-mux.yaml
- $ref: /schemas/i2c/i2c-controller.yaml#
properties:
--
2.43.0
The 'phandle-array' type is a bit ambiguous. It can be either just an
array of phandles or an array of phandles plus args. "i2c-parent" is
the former and needs to constrain each entry to a single phandle value.
Signed-off-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml b/Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml
index dd3d24212551..b813f6d4810c 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml
@@ -40,6 +40,8 @@ properties:
i2c-parent:
$ref: /schemas/types.yaml#/definitions/phandle-array
+ items:
+ maxItems: 1
description:
List of phandles of I2C masters available for selection. The first one
will be used as default.
--
2.43.0
On Wed, Jan 24, 2024 at 01:05:50PM -0600, Rob Herring wrote:
> The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not
> relevant and shouldn't be referenced.
>
> Signed-off-by: Rob Herring <[email protected]>
Reviewed-by: Wolfram Sang <[email protected]>
On Wed, Jan 24, 2024 at 01:05:51PM -0600, Rob Herring wrote:
> The 'phandle-array' type is a bit ambiguous. It can be either just an
> array of phandles or an array of phandles plus args. "i2c-parent" is
> the former and needs to constrain each entry to a single phandle value.
>
> Signed-off-by: Rob Herring <[email protected]>
Reviewed-by: Wolfram Sang <[email protected]>
On Sat, Feb 03, 2024 at 09:50:13PM +0100, Wolfram Sang wrote:
> On Wed, Jan 24, 2024 at 01:05:50PM -0600, Rob Herring wrote:
> > The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not
> > relevant and shouldn't be referenced.
> >
> > Signed-off-by: Rob Herring <[email protected]>
>
> Reviewed-by: Wolfram Sang <[email protected]>
Andi, can you pick these up?
Or you negotiate with Rob how you want to handle I2C DT patches. I
agreed with him that I usually take them. Except for generic cleanups or
so.
On Mon, Feb 26, 2024 at 4:48 AM Wolfram Sang
<[email protected]> wrote:
>
> On Sat, Feb 03, 2024 at 09:50:13PM +0100, Wolfram Sang wrote:
> > On Wed, Jan 24, 2024 at 01:05:50PM -0600, Rob Herring wrote:
> > > The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not
> > > relevant and shouldn't be referenced.
> > >
> > > Signed-off-by: Rob Herring <[email protected]>
> >
> > Reviewed-by: Wolfram Sang <[email protected]>
>
> Andi, can you pick these up?
I already did since you gave your reviewed-by and they hadn't
otherwise been picked up.
> Or you negotiate with Rob how you want to handle I2C DT patches. I
> agreed with him that I usually take them. Except for generic cleanups or
> so.
Yes, that is my preference. And how most subsystems work for bindings.
Rob
Hi Rob,
On Tue, Mar 05, 2024 at 12:06:05PM -0600, Rob Herring wrote:
> On Mon, Feb 26, 2024 at 4:48 AM Wolfram Sang
> > On Sat, Feb 03, 2024 at 09:50:13PM +0100, Wolfram Sang wrote:
> > > On Wed, Jan 24, 2024 at 01:05:50PM -0600, Rob Herring wrote:
> > > > The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not
> > > > relevant and shouldn't be referenced.
> > > >
> > > > Signed-off-by: Rob Herring <[email protected]>
> > >
> > > Reviewed-by: Wolfram Sang <[email protected]>
> >
> > Andi, can you pick these up?
>
> I already did since you gave your reviewed-by and they hadn't
> otherwise been picked up.
Oh... I had them in my test branch and was waiting for some more
tests before sending the notification.
Shall I remove them from my list?
Andi
Hi Rob,
On Wed, Mar 06, 2024 at 08:20:27AM +0100, Andi Shyti wrote:
> On Tue, Mar 05, 2024 at 12:06:05PM -0600, Rob Herring wrote:
> > On Mon, Feb 26, 2024 at 4:48 AM Wolfram Sang
> > > On Sat, Feb 03, 2024 at 09:50:13PM +0100, Wolfram Sang wrote:
> > > > On Wed, Jan 24, 2024 at 01:05:50PM -0600, Rob Herring wrote:
> > > > > The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not
> > > > > relevant and shouldn't be referenced.
> > > > >
> > > > > Signed-off-by: Rob Herring <[email protected]>
> > > >
> > > > Reviewed-by: Wolfram Sang <[email protected]>
> > >
> > > Andi, can you pick these up?
> >
> > I already did since you gave your reviewed-by and they hadn't
> > otherwise been picked up.
>
> Oh... I had them in my test branch and was waiting for some more
> tests before sending the notification.
>
> Shall I remove them from my list?
Because I need to update my branches, I am going to take these
two patches out. Please, let me know if you want me to take them
back in.
Thanks,
Andi