2024-01-24 15:35:18

by Chao Yu

Subject: [PATCH] f2fs: use printk_ratelimited to avoid redundant logs

Use printk_ratelimited() instead of f2fs_err() in f2fs_record_stop_reason(),
and f2fs_record_errors() to avoid redundant logs.

Signed-off-by: Chao Yu <[email protected]>
---
fs/f2fs/super.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index e2c066fbc0fa..7e437aea268e 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -4091,7 +4091,9 @@ static void f2fs_record_stop_reason(struct f2fs_sb_info *sbi)

f2fs_up_write(&sbi->sb_lock);
if (err)
- f2fs_err(sbi, "f2fs_commit_super fails to record err:%d", err);
+ printk_ratelimited(
+ "%sF2FS-fs (%s): f2fs_commit_super fails to record stop_reason, err:%d\n",
+ KERN_ERR, sbi->sb->s_id, err);
}

void f2fs_save_errors(struct f2fs_sb_info *sbi, unsigned char flag)
@@ -4134,8 +4136,9 @@ static void f2fs_record_errors(struct f2fs_sb_info *sbi, unsigned char error)

err = f2fs_commit_super(sbi, false);
if (err)
- f2fs_err(sbi, "f2fs_commit_super fails to record errors:%u, err:%d",
- error, err);
+ printk_ratelimited(
+ "%sF2FS-fs (%s): f2fs_commit_super fails to record errors:%u, err:%d\n",
+ KERN_ERR, sbi->sb->s_id, error, err);
out_unlock:
f2fs_up_write(&sbi->sb_lock);
}
--
2.40.1

2024-01-26 09:23:02

by Jaegeuk Kim

Subject: Re: [PATCH] f2fs: use printk_ratelimited to avoid redundant logs

On 01/24, Chao Yu wrote:
> Use printk_ratelimited() instead of f2fs_err() in f2fs_record_stop_reason(),
> and f2fs_record_errors() to avoid redundant logs.
>
> Signed-off-by: Chao Yu <[email protected]>
> ---
> fs/f2fs/super.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index e2c066fbc0fa..7e437aea268e 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -4091,7 +4091,9 @@ static void f2fs_record_stop_reason(struct f2fs_sb_info *sbi)
>
> f2fs_up_write(&sbi->sb_lock);
> if (err)
> - f2fs_err(sbi, "f2fs_commit_super fails to record err:%d", err);

Needing f2fs_err_ratelimited()?

> + printk_ratelimited(
> + "%sF2FS-fs (%s): f2fs_commit_super fails to record stop_reason, err:%d\n",
> + KERN_ERR, sbi->sb->s_id, err);
> }
>
> void f2fs_save_errors(struct f2fs_sb_info *sbi, unsigned char flag)
> @@ -4134,8 +4136,9 @@ static void f2fs_record_errors(struct f2fs_sb_info *sbi, unsigned char error)
>
> err = f2fs_commit_super(sbi, false);
> if (err)
> - f2fs_err(sbi, "f2fs_commit_super fails to record errors:%u, err:%d",
> - error, err);
> + printk_ratelimited(
> + "%sF2FS-fs (%s): f2fs_commit_super fails to record errors:%u, err:%d\n",
> + KERN_ERR, sbi->sb->s_id, error, err);
> out_unlock:
> f2fs_up_write(&sbi->sb_lock);
> }
> --
> 2.40.1

2024-01-26 13:00:57

by Chao Yu

Subject: Re: [PATCH] f2fs: use printk_ratelimited to avoid redundant logs

On 2024/1/26 16:42, Jaegeuk Kim wrote:
> On 01/24, Chao Yu wrote:
>> Use printk_ratelimited() instead of f2fs_err() in f2fs_record_stop_reason(),
>> and f2fs_record_errors() to avoid redundant logs.
>>
>> Signed-off-by: Chao Yu <[email protected]>
>> ---
>> fs/f2fs/super.c | 9 ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index e2c066fbc0fa..7e437aea268e 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -4091,7 +4091,9 @@ static void f2fs_record_stop_reason(struct f2fs_sb_info *sbi)
>>
>> f2fs_up_write(&sbi->sb_lock);
>> if (err)
>> - f2fs_err(sbi, "f2fs_commit_super fails to record err:%d", err);
>
> Needing f2fs_err_ratelimited()?

Yes, more clean, let me update in v2.

Thanks,

>
>> + printk_ratelimited(
>> + "%sF2FS-fs (%s): f2fs_commit_super fails to record stop_reason, err:%d\n",
>> + KERN_ERR, sbi->sb->s_id, err);
>> }
>>
>> void f2fs_save_errors(struct f2fs_sb_info *sbi, unsigned char flag)
>> @@ -4134,8 +4136,9 @@ static void f2fs_record_errors(struct f2fs_sb_info *sbi, unsigned char error)
>>
>> err = f2fs_commit_super(sbi, false);
>> if (err)
>> - f2fs_err(sbi, "f2fs_commit_super fails to record errors:%u, err:%d",
>> - error, err);
>> + printk_ratelimited(
>> + "%sF2FS-fs (%s): f2fs_commit_super fails to record errors:%u, err:%d\n",
>> + KERN_ERR, sbi->sb->s_id, error, err);
>> out_unlock:
>> f2fs_up_write(&sbi->sb_lock);
>> }
>> --
>> 2.40.1